Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create basic unit tests and document what's expected to work #112

Closed
noklam opened this issue Sep 16, 2024 · 1 comment
Closed

Create basic unit tests and document what's expected to work #112

noklam opened this issue Sep 16, 2024 · 1 comment
Labels
DevOps Making sure the extension work, testing documentation Improvements or additions to documentation

Comments

@noklam
Copy link
Contributor

noklam commented Sep 16, 2024

In general the extension leverage kedro as much as possible, there are small different for ergonomics reason which are not documented very clearly.

As the first step, I want this behavior to be test explicitly and create some unit tests for utils function in lsp_server.py which are easier to test. We do not have to test the Kedro components since this is covered already, instead focus on the special things about vscode extension.

for example:

  • _is_pipeline
  • _get_conf_path
  • _get_parameter_location
  • etc...
@noklam noklam added documentation Improvements or additions to documentation DevOps Making sure the extension work, testing labels Sep 23, 2024
@noklam noklam changed the title Create some unit tests and document what's expected to work Create basic unit tests and document what's expected to work Sep 25, 2024
@noklam noklam moved this to Todo in Kedro VS Code Sep 25, 2024
@noklam
Copy link
Contributor Author

noklam commented Sep 25, 2024

Closed as combined with #20

@noklam noklam closed this as completed Sep 25, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Kedro VS Code Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Making sure the extension work, testing documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

1 participant