Skip to content

Commit 1c99aed

Browse files
authored
fix: make change in capture response method to record tests (#106)
Signed-off-by: re-Tick <[email protected]> Signed-off-by: re-Tick <[email protected]>
1 parent 02725df commit 1c99aed

File tree

4 files changed

+52
-30
lines changed

4 files changed

+52
-30
lines changed

integrations/ksql/connBeginTx.go

+6-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ func (t Tx) Commit() error {
3636
case "test":
3737
// don't run
3838
case "capture":
39-
err = t.Tx.Commit()
39+
if t.Tx != nil {
40+
err = t.Tx.Commit()
41+
}
4042
default:
4143
return errors.New("integrations: Not in a valid sdk mode")
4244
}
@@ -79,7 +81,9 @@ func (t Tx) Rollback() error {
7981
case "test":
8082
// don't run
8183
case "capture":
82-
err = t.Tx.Rollback()
84+
if t.Tx != nil {
85+
err = t.Tx.Rollback()
86+
}
8387
default:
8488
return errors.New("integrations: Not in a valid sdk mode")
8589
}

integrations/ksql/connPrepareContext.go

+22-12
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,17 @@ func (s Stmt) Exec(args []driver.Value) (driver.Result, error) {
4545
case "test":
4646
//don't call method
4747
case "capture":
48-
result, err = s.Stmt.Exec(args)
49-
l, e := result.LastInsertId()
50-
drResult.LastInserted = l
51-
drResult.LError = e.Error()
52-
ra, e := result.RowsAffected()
53-
drResult.RowsAff = ra
54-
drResult.RError = e.Error()
48+
if s.Stmt != nil {
49+
result, err = s.Stmt.Exec(args)
50+
if result != nil {
51+
l, e := result.LastInsertId()
52+
drResult.LastInserted = l
53+
drResult.LError = e.Error()
54+
ra, e := result.RowsAffected()
55+
drResult.RowsAff = ra
56+
drResult.RError = e.Error()
57+
}
58+
}
5559
default:
5660
return nil, err
5761
}
@@ -94,8 +98,10 @@ func (s Stmt) Query(args []driver.Value) (driver.Rows, error) {
9498
case "test":
9599
// don't run
96100
case "capture":
97-
rows, err = s.Stmt.Query(args)
98-
drRows.Rows = rows
101+
if s.Stmt != nil {
102+
rows, err = s.Stmt.Query(args)
103+
drRows.Rows = rows
104+
}
99105
default:
100106
return nil, errors.New("integrations: Not in a valid sdk mode")
101107
}
@@ -138,8 +144,10 @@ func (s Stmt) NumInput() int {
138144
case "test":
139145
// don't run
140146
case "capture":
141-
o := s.Stmt.NumInput()
142-
output = &o
147+
if s.Stmt != nil {
148+
o := s.Stmt.NumInput()
149+
output = &o
150+
}
143151
default:
144152
return 0
145153
}
@@ -171,7 +179,9 @@ func (s Stmt) Close() error {
171179
case "test":
172180
// don't run
173181
case "capture":
174-
err = s.Stmt.Close()
182+
if s.Stmt != nil {
183+
err = s.Stmt.Close()
184+
}
175185
default:
176186
return errors.New("integrations: Not in a valid sdk mode")
177187
}

integrations/ksql/execerContext.go

+13-11
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,19 @@ func (c Conn) ExecContext(ctx context.Context, query string, args []driver.Named
6161
//don't call Find method
6262
case "capture":
6363
result, err = execerContext.ExecContext(ctx, query, args)
64-
// calls LastInsertId to capture their outputs
65-
li, e := result.LastInsertId()
66-
driverResult.LastInserted = li
67-
if e != nil {
68-
driverResult.LError = e.Error()
69-
}
70-
// calls RowsAffected to capture their outputs
71-
ra, e := result.RowsAffected()
72-
driverResult.RowsAff = ra
73-
if e != nil {
74-
driverResult.RError = e.Error()
64+
if result != nil {
65+
// calls LastInsertId to capture their outputs
66+
li, e := result.LastInsertId()
67+
driverResult.LastInserted = li
68+
if e != nil {
69+
driverResult.LError = e.Error()
70+
}
71+
// calls RowsAffected to capture their outputs
72+
ra, e := result.RowsAffected()
73+
driverResult.RowsAff = ra
74+
if e != nil {
75+
driverResult.RError = e.Error()
76+
}
7577
}
7678
default:
7779
return result, err

integrations/ksql/queryerContext.go

+11-5
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,10 @@ func (r Rows) Columns() []string {
4040
case "test":
4141
// don't run
4242
case "capture":
43-
o := r.Rows.Columns()
44-
output = &o
43+
if r.Rows != nil {
44+
o := r.Rows.Columns()
45+
output = &o
46+
}
4547
default:
4648
return nil
4749
}
@@ -80,7 +82,9 @@ func (r Rows) Close() error {
8082
return nil
8183
}
8284
case "capture":
83-
err = r.Rows.Close()
85+
if r.Rows != nil {
86+
err = r.Rows.Close()
87+
}
8488
default:
8589
return errors.New("integrations: Not in a valid sdk mode")
8690
}
@@ -237,8 +241,10 @@ func (r Rows) Next(dest []driver.Value) error {
237241
case "test":
238242
// don't run
239243
case "capture":
240-
err = r.Rows.Next(dest)
241-
output.Value = dest
244+
if r.Rows != nil {
245+
err = r.Rows.Next(dest)
246+
output.Value = dest
247+
}
242248
default:
243249
return errors.New("integrations: Not in a valid sdk mode")
244250
}

0 commit comments

Comments
 (0)