Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tests for lifecycle-operator bugs #3121

Open
odubajDT opened this issue Feb 26, 2024 · 13 comments
Open

Introduce tests for lifecycle-operator bugs #3121

odubajDT opened this issue Feb 26, 2024 · 13 comments

Comments

@odubajDT odubajDT self-assigned this Feb 26, 2024
@odubajDT odubajDT removed their assignment Feb 26, 2024
@odubajDT odubajDT changed the title Introduce regression tests for lifecycle-operator bugs Introduce more tests for lifecycle-operator functionality Feb 26, 2024
@odubajDT odubajDT changed the title Introduce more tests for lifecycle-operator functionality Introduce tests for lifecycle-operator bugs Feb 26, 2024
@odubajDT odubajDT added good first issue Good for newcomers status: ready-for-refinement Issue is relevant for the next backlog refinment labels Feb 26, 2024
@SohamRatnaparkhi
Copy link

Hi @odubajDT , I can try to solve this issue. Can you assign it to me?

Thank you!

@odubajDT odubajDT removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Feb 27, 2024
@mowies mowies moved this to 🏃 In progress in Keptn Lifecycle Toolkit Feb 28, 2024
@odubajDT
Copy link
Contributor Author

odubajDT commented Mar 8, 2024

Hi @SohamRatnaparkhi are you actively working on this issue? Since you have this issue assigned for aprox. 10 days, we usually unassign asignees from their issues if there is no activity to not block other potential contributors from starting to tackle them.

Thanks for the update!

@SohamRatnaparkhi
Copy link

Hey @odubajDT
Really sorry for holding on to the issue. I'm busy right now and can't solve it. Feel free to assign it to someone else.

Once again, I'm really sorry :)

@odubajDT
Copy link
Contributor Author

odubajDT commented Mar 8, 2024

No worries, thank you very much for your answer! :) If you have time in the future, we would be happy if you reach out to us for potentially another issue!

@mowies mowies moved this from 🏃 In progress to 🎟️ Refined in Keptn Lifecycle Toolkit Mar 11, 2024
@Bharadwajshivam28
Copy link
Contributor

Hey I can take on this one If no one is working

@odubajDT
Copy link
Contributor Author

odubajDT commented Apr 2, 2024

Hi @Bharadwajshivam28 are you actively working on this issue? Since you have this issue assigned for aprox. 3 weeks, we usually unassign asignees from their issues if there is no activity to not block other potential contributors from starting to tackle them.

Thanks for the update!

@odubajDT
Copy link
Contributor Author

odubajDT commented Apr 3, 2024

Due to inactivity, unassigning @Bharadwajshivam28 from this issue. Feel free to request a different issue!

@odubajDT odubajDT removed the good first issue Good for newcomers label Apr 3, 2024
@odubajDT odubajDT assigned odubajDT and unassigned odubajDT Apr 3, 2024
@odubajDT odubajDT added the good first issue Good for newcomers label Apr 4, 2024
@YashPimple
Copy link
Member

Hi @odubajDT I would like to work on the above issue

@odubajDT odubajDT assigned odubajDT and YashPimple and unassigned odubajDT Apr 9, 2024
@odubajDT
Copy link
Contributor Author

odubajDT commented Apr 9, 2024

@YashPimple I assigned it to you but please before you start, there is a small change required in the PR you have opened #3143. try to please finish this one first before you start with a new one

@Jay179-sudo
Copy link
Contributor

Hi! @odubajDT, I would like to take up this issue.

Since the non-blocking mode does not introduce any errors in the controller, we can write a unit test with a mock handler that does not return any errors when the KeptnAppVersionStatus resembles the manifest in the docs

Am I correctly understanding the task here?

@mowies
Copy link
Member

mowies commented Jul 10, 2024

@Jay179-sudo sure thing, I assigned it to you

Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@mowies
Copy link
Member

mowies commented Oct 10, 2024

un-assigning, due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🎟️ Refined
Development

No branches or pull requests

6 participants