Make use of the insecureSkipTlsVerify in the prometheus basicAuthRoundTripper

[odubajDT]

In the current implementation, Keptn is using the basicAuthRoundTripper for creating a http client which is able to skip the TLS verification.

We should make use of the already existing parameter and instead of using the DefaultRoundTripper, we should create a custom one with the usage of the insecureSkipTlsVerify parameter in its config. This way, we should be able to use the value of the parameter in the used roudTripper and enable the user to skip/not skip the TLS verification.

[Bharadwajshivam28]

Hey @mowies I would love to work on this

[odubajDT]

Hello @Bharadwajshivam28! Thank, you, assigned!

[Bharadwajshivam28]

Hello @Bharadwajshivam28! Thank, you, assigned!

Thanks

[odubajDT]

Hey @Bharadwajshivam28 thank you for the PR, unfortunately we found out that there is no need to use the TLSRoundTripper for the prometheus provider to actually enable skipping the tls verification. It should be enough just to adapt the configuration of the currently used basicRoundTripper. I adapted the description of the ticket for more guidance.

Sorry for the requirement changes!

[Bharadwajshivam28]

Hey @Bharadwajshivam28 thank you for the PR, unfortunately we found out that there is no need to use the TLSRoundTripper for the prometheus provider to actually enable skipping the tls verification. It should be enough just to adapt the configuration of the currently used basicRoundTripper. I adapted the description of the ticket for more guidance.

Sorry for the requirement changes!

okay I have seen the description and will make changes in the codebase accordingly

[github-actions]

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.