Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModernBERT to KerasHub #2027

Open
gcuder opened this issue Dec 23, 2024 · 2 comments
Open

Add ModernBERT to KerasHub #2027

gcuder opened this issue Dec 23, 2024 · 2 comments
Assignees
Labels
type:feature New feature or request

Comments

@gcuder
Copy link

gcuder commented Dec 23, 2024

ModernBERT has been released on HuggingFace. Since you can already load models from there into a Keras Backbone, it would be interesting to know, if this works as well.

https://huggingface.co/answerdotai/ModernBERT-base

@mattdangerw mattdangerw added the type:feature New feature or request label Jan 8, 2025
@mattdangerw mattdangerw changed the title Does ModernBERT work out of the box with Keras 3? Add ModernBERT to KerasHub Jan 8, 2025
@mattdangerw
Copy link
Member

It does not yet work, as our Bert implementation does not support RoPE and alternating local/global attention.

Likely we would want to do this as a separate architecture (e.g. in a models/modern_bert/ directory), instead of sharing code with BERT, as its a substantially different architecture.

But we are planning to add it! It's a great fit for our library.

@gcuder
Copy link
Author

gcuder commented Jan 9, 2025

Cool, let me know if I can help contributing to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants