-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False detections on surface pro #212
Comments
For Physical connection ports, running |
Debug level info is:
|
Hi! did you run the library by cloning the main branch or from the release? There seems to be something terribly wrong if you're running on a host and 6 false positives appeared. And thanks for the debug info, I was about to ask for an output of the debug binary :) Is it possible if you can show the full one however? There are some outputs that are necessary to determine what's going on.(P.S. there is a technique that shows the mac address which you should delete from the output and neither is it important for us to know) |
Built using microsoft
Important to note is that I run some VMs on this PC, but this is ran inside of the Developer powershell on the bare metal OS. |
The issue is definitely because of your motherboard. We had no idea that Microsoft made their own motherboards, and one of our mechanisms called Hyper-X depends on the motherboard string as one of the data it uses, and determined you were running in a Hyper-V VM. A few techniques we've implemented depends on our Hyper-X mechanism, which is what caused a cascade of false positives to appear in your case. This will be fixed in the 2.1 release really soon. In the meantime, I'll keep this issue opened until it's fully fixed. I sort of need time to discuss with my co-maintainer about a few things we could do. But anyways, thanks for reporting the issue :) |
Output:
VirtualPC Motherboard:
I suspect this is triggering due to the fact that my motherboard is made by microsoft, funnily enough.
As for the other ones, I'm unsure, but happy to provide whatever details to hopefully get to a fix.
The text was updated successfully, but these errors were encountered: