Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving all demo flow blueprints into a demo folder #57

Closed
anna-geller opened this issue Feb 10, 2025 · 4 comments
Closed

Consider moving all demo flow blueprints into a demo folder #57

anna-geller opened this issue Feb 10, 2025 · 4 comments
Assignees
Labels
area/docs Issues related to documentation, plugin examples, blueprints, and guides

Comments

@anna-geller
Copy link
Member

So far, we were using the demo: true property in the extend metadata to highlight which blueprints can be used for QA https://github.com/kestra-io/blueprints/blob/main/flows/api-python-sql.yaml#L63

This was working great in Strapi but now it's cumbersome for QA

@anna-geller anna-geller added the area/docs Issues related to documentation, plugin examples, blueprints, and guides label Feb 10, 2025
@kestrabot kestrabot bot added this to Issues Feb 10, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Issues Feb 10, 2025
@anna-geller
Copy link
Member Author

Ben assigned you just to make it clear you're in charge here to coordinate 👍

@anna-geller anna-geller moved this from Backlog to In progress in Issues Feb 10, 2025
@Ben8t
Copy link
Member

Ben8t commented Feb 12, 2025

using the demo: true property in the extend metadata to highlight which blueprints can be used for QA

@anna-geller I'm not sure it was the primary usage. After looking at some of them, many has secret or taskRunner: process that make it hard to use for QA (either lack of creds. or because of limited taskRunner to Docker)

I was about to move some of the demo: true to demo:false but I think it was related to the actual demo we provided directly from the website.

-> Are we ok to remove some demo:true (even if it's a good blueprint for "demo" of Kestra - just not working per se, in a self-contained way)?

By the way, I've worked on a CI that take blueprints, parse the extend props. and only use the one with demo:true (cf here) as sanitycheck (and remove the extend property so we could resolve kestra-io/kestra#6385)

@anna-geller
Copy link
Member Author

yes for sure, if some demo: true are not working as expected (self-contained), we should either fix them or set demo: false

@Ben8t
Copy link
Member

Ben8t commented Feb 25, 2025

Closing this one as I removed the demo: true for blueprints which are not self contained here.

@Ben8t Ben8t closed this as completed Feb 25, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Issues Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Issues related to documentation, plugin examples, blueprints, and guides
Projects
Status: Done
Development

No branches or pull requests

2 participants