Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Topology - Node broken when opening a subflow #7488

Open
Skraye opened this issue Feb 19, 2025 · 6 comments
Open

UI - Topology - Node broken when opening a subflow #7488

Skraye opened this issue Feb 19, 2025 · 6 comments
Assignees
Labels
area/frontend Needs frontend code changes bug Something isn't working kind/backport-needed Issue that needs to be backported to a previous version

Comments

@Skraye
Copy link
Member

Skraye commented Feb 19, 2025

Describe the issue

When you open a subflow (the broken hello node is the parent class):

Image

Environment

  • Kestra Version: develop
@Skraye Skraye added area/frontend Needs frontend code changes bug Something isn't working labels Feb 19, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Issues Feb 19, 2025
@anna-geller
Copy link
Member

reproducer:

id: child
namespace: company.team

tasks:
  - id: hello
    type: io.kestra.plugin.core.log.Log
    message: Hello World! 

and:

id: parent
namespace: company.team

tasks:
  - id: hello
    type: io.kestra.plugin.core.flow.Subflow
    namespace: company.team
    flowId: child

@tchiotludo tchiotludo added the kind/backport-needed Issue that needs to be backported to a previous version label Feb 25, 2025
@MilosPaunovic
Copy link
Member

@Skraye Is this is something that needs fixing on the BE, node generation side, or do you think it's more of a question of Topology component rendering?

@Skraye
Copy link
Member Author

Skraye commented Feb 26, 2025

I think its an issue with Topology component

@anna-geller
Copy link
Member

also broken on latest, needs to be included in the bugfix

image

@MilosPaunovic
Copy link
Member

I've done a dive into the Topology.vue component from ui-libs and all related ones in main repository, and could not find what the problem is.

Right now, it seems that on expand click we are calling generateGraph method which is using props.flowGraph as the source, and that is a field in flow.js store module, directly from endpoint.

Not really sure on how to proceed here... Could you guide me a bit if you have any ideas @Skraye @brian-mulier-p?

@anna-geller anna-geller assigned Skraye and unassigned MilosPaunovic Feb 26, 2025
@Ben8t
Copy link
Member

Ben8t commented Feb 26, 2025

link to #4902 (this one is related to execution topology, not flow one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working kind/backport-needed Issue that needs to be backported to a previous version
Projects
Status: Backlog
Development

No branches or pull requests

5 participants