You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is about make sure that keycloak.js adapter can be tested in the keycloak/keycloak-js repository. It is about moving the tests for javascript adapter from the main repository to the new one.
AFAIK the existing of keycloak.js adapter is only JavascriptAdapterTest in the arquillian testsuite in the main Keycloak arquillian testsuite. So we need to have at least the coverage like this test in the new keycloak.js repository.
It seems we need to figure:
What framework etc to use for testing?
How to provision Keycloak server during tests of keycloak.js?
Few points:
Do we want to use Java for the testing? We can probably use the new test framework (which also takes care of server provisioning etc). Advantage is, that it can be probably easier to move the existing Java test JavascriptAdapterTest . Disadvantage is, that we will need Java in the non-java keycloak/keycloak-js project (as adapter itself does not need Java for anything). Had brief discussion with @stianst and he suggests to not use Java at all in keycloak-js adapter repository..
Can we use something like quickstarts for the JS adapter are using? The provisioning of the Keycloak server is done by the bash script in quickstarts and manual downloading of the server as a ZIP etc (not so pretty way...)
Some other approach?
The text was updated successfully, but these errors were encountered:
This is about make sure that keycloak.js adapter can be tested in the
keycloak/keycloak-js
repository. It is about moving the tests for javascript adapter from the main repository to the new one.AFAIK the existing of keycloak.js adapter is only
JavascriptAdapterTest
in the arquillian testsuite in the main Keycloak arquillian testsuite. So we need to have at least the coverage like this test in the new keycloak.js repository.It seems we need to figure:
Few points:
Do we want to use Java for the testing? We can probably use the new test framework (which also takes care of server provisioning etc). Advantage is, that it can be probably easier to move the existing Java test
JavascriptAdapterTest
. Disadvantage is, that we will need Java in the non-java keycloak/keycloak-js project (as adapter itself does not need Java for anything). Had brief discussion with @stianst and he suggests to not use Java at all in keycloak-js adapter repository..Can we use something similar like node.js testsuite in the node.js repository https://github.com/keycloak/keycloak-nodejs-connect ?
Can we use something like quickstarts for the JS adapter are using? The provisioning of the Keycloak server is done by the bash script in quickstarts and manual downloading of the server as a ZIP etc (not so pretty way...)
Some other approach?
The text was updated successfully, but these errors were encountered: