Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests for Keycloak JS into own repo #4

Open
Tracked by #7
mposolda opened this issue Jan 21, 2025 · 0 comments
Open
Tracked by #7

Move tests for Keycloak JS into own repo #4

mposolda opened this issue Jan 21, 2025 · 0 comments

Comments

@mposolda
Copy link
Contributor

mposolda commented Jan 21, 2025

This is about make sure that keycloak.js adapter can be tested in the keycloak/keycloak-js repository. It is about moving the tests for javascript adapter from the main repository to the new one.

AFAIK the existing of keycloak.js adapter is only JavascriptAdapterTest in the arquillian testsuite in the main Keycloak arquillian testsuite. So we need to have at least the coverage like this test in the new keycloak.js repository.

It seems we need to figure:

  • What framework etc to use for testing?
  • How to provision Keycloak server during tests of keycloak.js?

Few points:

  • Do we want to use Java for the testing? We can probably use the new test framework (which also takes care of server provisioning etc). Advantage is, that it can be probably easier to move the existing Java test JavascriptAdapterTest . Disadvantage is, that we will need Java in the non-java keycloak/keycloak-js project (as adapter itself does not need Java for anything). Had brief discussion with @stianst and he suggests to not use Java at all in keycloak-js adapter repository..

  • Can we use something similar like node.js testsuite in the node.js repository https://github.com/keycloak/keycloak-nodejs-connect ?

  • Can we use something like quickstarts for the JS adapter are using? The provisioning of the Keycloak server is done by the bash script in quickstarts and manual downloading of the server as a ZIP etc (not so pretty way...)

  • Some other approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant