-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: keyboard search includes sil_euro_latin when searching for "han script" #3221
Comments
This happens because sil_euro_latin includes See the api search result -- the "match": {
"name": "Han",
"type": "script",
"weight": 10,
"downloads": 1041,
"totalDownloads": 47470,
"finalWeight": 79.4889722231331,
"tag": "zhd"
} And looking at sil_euro_latin.kps: <Language ID="zhd">Dai Zhuang</Language> So, this is a bug in sil_euro_latin -- because langtags.json shows that the default script for {
"full": "zhd-Hani-CN",
"iana": [ "Dai Zhuang" ],
"iso639_3": "zhd",
"macrolang": "za",
"name": "Zhuang, Dai",
"names": [ "Bu Dai", "Dai Zhuang", "Kau Ndae", "Khaau Daai", "Thu Lao", "Tu", "Tuliao", "Tuzu", "Wen-Ma Southern Zhuang", "Zhuangyu Nanbu Fangyan Wen-Ma Tuyu", "Zhuangyu Nanbu fangyan Dejing tuyu" ],
"region": "CN",
"regionname": "China",
"regions": [ "VN" ],
"script": "Hani",
"sldr": false,
"tag": "zhd",
"tags": [ "zhd-CN", "zhd-Hani" ],
"windows": "zhd-Hani"
},
{
"full": "zhd-Latn-VN",
"iana": [ "Dai Zhuang" ],
"iso639_3": "zhd",
"macrolang": "za",
"name": "Zhuang, Dai",
"names": [ "Bu Dai", "Dai Zhuang", "Kau Ndae", "Khaau Daai", "Thu Lao", "Tu", "Tuliao", "Tuzu", "Wen-Ma Southern Zhuang", "Zhuangyu Nanbu Fangyan Wen-Ma Tuyu", "Zhuangyu Nanbu fangyan Dejing tuyu" ],
"obsolete": true,
"region": "VN",
"regionname": "Viet Nam",
"regions": [ "CN" ],
"script": "Latn",
"sldr": false,
"tag": "zhd-Latn",
"tags": [ "zhd-VN" ],
"windows": "zhd-Latn"
}, |
Note: I haven't verified the other tags. It'd be good for a package build to verify the script tags are the same for all referenced BCP 47 languages (and hint on mismatches) |
After implementing a test in kmc-keyboard-info against keymanapp/keyman#12752, I got the following report:
This is an indication that there may be an error in the language tag, but not necessarily conclusive, which is why it is reported only as a HINT. |
Arbore keyboard - needed to update langtags to support bu_phonetic - there is no 2 of the basic keyboards (basic_kbdinuk2, basic_kbdiulat) support both Latin and Cans. The language tags are |
Given There is a separate problem with
I think in these cases we just ignore the hint. That's why I made it a hint rather than a warning or error -- it may not be something we can fix. (Once we support keymanapp/keyman#10397, then we can disable the hint at a project level, which would be great.) |
I was testing localizing keyboard searches and didn't understand why sil_euro_latin appeared in the list when searching for
s:han
(han script)Repros on the live site:
https://keyman.com/keyboards?q=s%3Ahan
I'm not finding "han script" in the api.keyman.com blob
https://api.keyman.com/keyboard/sil_euro_latin
The text was updated successfully, but these errors were encountered: