Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Sass: @import "site/variables" should be before bootstrap import #269

Open
alabama opened this issue Dec 17, 2017 · 1 comment
Open

Sass: @import "site/variables" should be before bootstrap import #269

alabama opened this issue Dec 17, 2017 · 1 comment

Comments

@alabama
Copy link

alabama commented Dec 17, 2017

When using sass as css pre-processor the file:

site.scss

imports the site/variables file after it imports the bootstrap files. This has no effect on overriding default bootstrap variables. Problem is also discussed here:
https://discourse.roots.io/t/how-to-override-boostrap-variables-in-sass/3729

Maybe we could create a bootstrap-variables file, which should only contain the wanted overrides of the bootstrap variables and place the import before the bootstrap import in the site.scss file. The default variables file can still be called after that.

What do you guys think about that?

@codenamezjames
Copy link

codenamezjames commented Aug 27, 2018

+1 I was all like.. Wtf I know this is the right variable name.. whats going on. I didn't realize until I made it here that it was after the bootstrap CSS by default.

Especially considering the comment in the CSS file says

// The easiest way to customise Bootstrap variables while
// being able to easily override the source files with newa
// versions is to override the ones you want in another file.

also, we should fix the spelling of customize :)
Stupid American! customise is right outside of the US! I just looked it up. 😝

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants