Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed validating 'multipleOf' in schema #15

Open
ian-lewis-d opened this issue Nov 2, 2023 · 2 comments · May be fixed by #16
Open

Failed validating 'multipleOf' in schema #15

ian-lewis-d opened this issue Nov 2, 2023 · 2 comments · May be fixed by #16

Comments

@ian-lewis-d
Copy link

Hi,

I am encountering json schema validation errors with floating point values.

I have tried converting the problematic fields to String using stream maps but it appears to have zero effect.

Can you suggest any way around this issue?

I've seen a solution, where floats are converted to Decimal, from Edgar Ramirez that was pushed to the Singer SDK but it appears target-singer-jsonl does not use the SDK.
@pnadolny13
Copy link

A similar issue was raised in target-snowflake MeltanoLabs/target-snowflake#66. I think this was the SDK issue meltano/sdk#344 and PR to fix it meltano/sdk#1809.

@pnadolny13 pnadolny13 linked a pull request Nov 3, 2023 that will close this issue
Open
@pnadolny13
Copy link

pnadolny13 commented Nov 3, 2023 •
edited
Loading

@ian-lewis-d I'm not 100% sure this fixes it so you'd have to test but I created a PR to match the fix from the SDK #16.

You can test locally by updating your meltano.yml pip_url to git+https://github.com/pnadolny13/target-singer-jsonl.git@patch-1 then running meltano install loader target-singer-jsonl --clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Handle Decimals similar to SDK pnadolny13/target-singer-jsonl
2 participants
@pnadolny13 @ian-lewis-d