-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preventOverrun
maybe not working for CronJob
#195
Comments
👋 I can not find any code in toad-scheduler that translate option |
@Hexagon is it turned off by default? |
@kibertoad Yes it is, i see now that default is "undefined" according to the docs, will change that to false to clarify |
thanks, I'll fix then! |
it looks like it's explicitly turned off regardless of the option supplied:
constructor(schedule: CronSchedule, task: Task | AsyncTask, options: JobOptions = {}) {
super(options.id)
this.preventOverrun = false // xxx
this.schedule = schedule
this.task = task
} |
Fixed in 3.0.1, sorry for taking so long, writing a working test for this was much trickier than expected. |
Hi,
first of alle thanks for the great work!
Here is an example where a CronJob an a SimpleIntervalJob are created both with an Interval of 10 seconds and the same task which takes > 17 seconds to execute and both with the option
preventOverrun
.While the SimpleIntervalJob works and is only started every second time (20 seconds) the Cronjob is called every 10 seconds.
It seems like the option is not working for CronJobs or am i'm doing something wrong?
I am using version 3.0.0.
Thanks in advance
The text was updated successfully, but these errors were encountered: