You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously, we had separate components for:
Text only (Text)
Image + Text (ImageText)
Image only(Image)
Each component had properties specific to its individual use case.
Current State:
Image has been removed. ImageText is now used for "image only" use cases by not utilizing the text part of the component.
This makes Text redundant as ImageText can also be used for "text only" use cases. The implication before the removal was a strict separation of all use cases by component. This has changed now.
Suggestion:
Merge the ImageText and Text into a single unified component.
The unified component should support the following combinations:
Text only
Image only
Image and Text
This should be achieved through the required attribute in the JSON schema and example stories, rather than an explicit property.
Action Items:
Update the JSON schema to reflect the unified component.
Create example stories demonstrating the different use cases (Text only, Image only, Image and Text).
Update documentation to reflect the changes and guide users on how to use the unified component.
The text was updated successfully, but these errors were encountered:
julrich
transferred this issue from kickstartDS/ds-agency-premium
Dec 5, 2024
julrich
changed the title
TBD: Consolidation of Text, ImageText, and Image Components
Consolidation of Text, ImageText, and Image Components
Dec 5, 2024
We keep ImageText and Text. Adjust required fields for ImageText for update use. ImageText should work for image only scenarios, where-as Text should serve text-specific stuff (multi-column, etc).
Previously, we had separate components for:
Text only (
Text
)Image + Text (
ImageText
)Image only(
Image
)Each component had properties specific to its individual use case.
Current State:
Image
has been removed.ImageText
is now used for "image only" use cases by not utilizing the text part of the component.This makes
Text
redundant asImageText
can also be used for "text only" use cases. The implication before the removal was a strict separation of all use cases by component. This has changed now.Suggestion:
Merge the
ImageText
andText
into a single unified component.The unified component should support the following combinations:
This should be achieved through the required attribute in the JSON schema and example stories, rather than an explicit property.
Action Items:
Update the JSON schema to reflect the unified component.
Create example stories demonstrating the different use cases (Text only, Image only, Image and Text).
Update documentation to reflect the changes and guide users on how to use the unified component.
The text was updated successfully, but these errors were encountered: