You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are different definitions of buttons in our current components, and adjacent definitions like links that share a lot of component API. Different in this context means differences in their defined properties.
Those should be aligned, and respectively named differently (different use case -> different name, don't reuse buttons as a catch-all).
There are different definitions of
buttons
in our current components, and adjacent definitions likelinks
that share a lot of component API. Different in this context means differences in their defined properties.Those should be aligned, and respectively named differently (different use case -> different name, don't reuse
buttons
as a catch-all).Some examples (
buttons
):label
,icon
,target
:Cta
: https://github.com/kickstartDS/ds-agency-premium/blob/main/src/components/cta/cta.schema.json#L45-L62Hero
: https://github.com/kickstartDS/ds-agency-premium/blob/main/src/components/hero/hero.schema.json#L49-L66Video Curtain
: https://github.com/kickstartDS/ds-agency-premium/blob/main/src/components/video-curtain/video-curtain.schema.json#L37-L54Button Group
/label
,target
,variant
,icon
,size
,disabled
:Image Story
: https://github.com/kickstartDS/ds-agency-premium/blob/main/src/components/video-curtain/video-curtain.schema.json#L37-L54Section
: https://github.com/kickstartDS/ds-agency-premium/blob/main/src/components/section/section.schema.json#L219-L221Examples (
links
):icon
,label
,href
,newTab
:Contact
: https://github.com/kickstartDS/ds-agency-premium/blob/main/src/components/contact/contact.schema.json#L51-L90Blog Author
: https://github.com/kickstartDS/ds-agency-premium/blob/main/src/components/blog-author/blog-author.schema.json#L23-L25The text was updated successfully, but these errors were encountered: