Simplify CTA #40
Open
Simplify CTA #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julrich Können wir uns nächste Woche mal die integration hiervon anschauen? |
|
Schon, sollten wir aber auch mal mit @DanielLeyUX besprechen. Vertical content align würde ich z.B. nicht zwingend löschen? |
|
Das wurde nicht gelöscht sondern durch 2 spezifischere Werte ersetzt. Einmal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CTA component was previously overloaded with complexity and was overwriting much of the underlying storytelling layout, making it challenging to customize and develop. These changes simplify the CTA component by removing many of the dsa-specific layout overrides and making a few additions to enhance transparency for developers and content editors.
Its important to note that properties were changed and removed, changed an new ones added!
📦 Published PR as canary version:
1.6.65--canary.40.1537.0✨ Test out this PR locally via: