From fd788632cf45a597d5e8c09ded6acdf37cb1b8bd Mon Sep 17 00:00:00 2001 From: Kusuma04-dev Date: Thu, 2 Jan 2025 19:00:56 +0530 Subject: [PATCH 1/3] kie-issues#1725: KIE Tools: folder indicator is lost (#2824) Co-authored-by: chinnamatli kusumalatha --- packages/online-editor/src/home/HomePage.tsx | 112 ++++++++++--------- 1 file changed, 57 insertions(+), 55 deletions(-) diff --git a/packages/online-editor/src/home/HomePage.tsx b/packages/online-editor/src/home/HomePage.tsx index b0a7f639172..55004e5f74e 100644 --- a/packages/online-editor/src/home/HomePage.tsx +++ b/packages/online-editor/src/home/HomePage.tsx @@ -320,62 +320,64 @@ export function WorkspaceCard(props: { rejected={() => <>ERROR} resolved={(workspace) => ( <> - {(editableFiles.length === 1 && workspace.descriptor.origin.kind === WorkspaceKind.LOCAL && ( - setHovered(true)} - onMouseLeave={() => setHovered(false)} - isHoverable={true} - isCompact={true} - style={{ cursor: "pointer" }} - onClick={() => { - history.push({ - pathname: routes.workspaceWithFilePath.path({ - workspaceId: editableFiles[0].workspaceId, - fileRelativePath: editableFiles[0].relativePathWithoutExtension, - extension: editableFiles[0].extension, - }), - }); - }} - > - - - - setHovered(true)} + onMouseLeave={() => setHovered(false)} + isHoverable={true} + isCompact={true} + style={{ cursor: "pointer" }} + onClick={() => { + history.push({ + pathname: routes.workspaceWithFilePath.path({ + workspaceId: editableFiles[0].workspaceId, + fileRelativePath: editableFiles[0].relativePathWithoutExtension, + extension: editableFiles[0].extension, + }), + }); + }} + > + + + + + + + e.stopPropagation()} // Prevent bug when clicking at the backdrop of ResponsiveDropdown + > + { + props.onDelete?.(); + workspaces.deleteWorkspace({ workspaceId: props.workspaceId }); + }} + item={ + + + Delete {`"${editableFiles[0].nameWithoutExtension}"`} + + + + + + + + } /> - - - e.stopPropagation()} // Prevent bug when clicking at the backdrop of ResponsiveDropdown - > - { - props.onDelete?.(); - workspaces.deleteWorkspace({ workspaceId: props.workspaceId }); - }} - item={ - - - Delete {`"${editableFiles[0].nameWithoutExtension}"`} - - - - - - - - } - /> - - - - )) || ( + + + + )) || ( Date: Fri, 3 Jan 2025 18:27:56 +0530 Subject: [PATCH 2/3] kie-issues#2821: KIE Tools: TypeError when invoking Java method inside BKM (#2831) Co-authored-by: chinnamatli kusumalatha --- .../JavaFunctionExpression.tsx | 46 +++++++++++-------- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/packages/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx b/packages/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx index 5f2b882f6a8..bc144facf01 100644 --- a/packages/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx +++ b/packages/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx @@ -332,21 +332,25 @@ export function JavaFunctionExpression({ // Class if (u.rowIndex === 0) { setExpression((prev: Normalized) => { - clazz.expression = { - ...clazz.expression, - __$$element: "literalExpression", - text: { - __$$text: u.value, - }, - }; - // Do not inline this variable for type safety. See https://github.com/microsoft/TypeScript/issues/241 const ret: Normalized = { ...prev, expression: { __$$element: "context", ...context, - contextEntry: [clazz, method], + contextEntry: [ + { + ...clazz, + expression: { + ...clazz.expression, + __$$element: "literalExpression", + text: { + __$$text: u.value, + }, + }, + }, + method, + ], }, }; @@ -356,22 +360,26 @@ export function JavaFunctionExpression({ // Method else if (u.rowIndex === 1) { setExpression((prev: Normalized) => { - method.expression = { - ...method.expression, - __$$element: "literalExpression", - "@_id": method.expression["@_id"] ?? generateUuid(), - text: { - __$$text: u.value, - }, - }; - // Do not inline this variable for type safety. See https://github.com/microsoft/TypeScript/issues/241 const ret: Normalized = { ...prev, expression: { __$$element: "context", ...context, - contextEntry: [clazz, method], + contextEntry: [ + clazz, + { + ...method, + expression: { + ...method.expression, + __$$element: "literalExpression", + "@_id": method.expression["@_id"] ?? generateUuid(), + text: { + __$$text: u.value, + }, + }, + }, + ], }, }; return ret; From 48aa13382de3b7049bba14dd86eae941415ed5e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Han=C3=A1k?= Date: Tue, 7 Jan 2025 10:49:07 +0100 Subject: [PATCH 3/3] [kn-plugin-workflow] NO_ISSUE: Fix typo in gen_manifest help text (#2832) --- packages/kn-plugin-workflow/pkg/command/gen_manifest.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kn-plugin-workflow/pkg/command/gen_manifest.go b/packages/kn-plugin-workflow/pkg/command/gen_manifest.go index 53e996f059e..b7dc0b6a7c5 100644 --- a/packages/kn-plugin-workflow/pkg/command/gen_manifest.go +++ b/packages/kn-plugin-workflow/pkg/command/gen_manifest.go @@ -52,7 +52,7 @@ func NewGenManifest() *cobra.Command { {{.Name}} gen-manifest --skip-namespace # Persist the generated Operator manifests on a specific custom path - {{.Name}} gen-manifest --custom-generated-manifest-dir= + {{.Name}} gen-manifest --custom-generated-manifests-dir= # Specify a custom subflows files directory. (default: ./subflows) {{.Name}} gen-manifest --subflows-dir=