Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Google Play update script to allow updates without content change #67

Open
kelson42 opened this issue Mar 18, 2017 · 16 comments
Open
Assignees

Comments

@kelson42
Copy link
Contributor

From @mhutti1 on December 30, 2016 18:9

upload-apk.py should be updated to allow for uploading APKs with an existing expansion. For now this operation can only be achieved using the Google Play Admin Web UI.

Copied from original issue: kiwix/kiwix-xulrunner#407

@kelson42
Copy link
Contributor Author

From @mhutti1 on December 30, 2016 18:9

@kelson42 as this requires an API key to test its not really suitable for GCI.

@kelson42
Copy link
Contributor Author

@mhutti1 AFAIK update-play-store.py is only there to update the play store meta data, not to upload APK. So it is not clear to me which problem this ticket should solve.

@kelson42
Copy link
Contributor Author

From @mhutti1 on December 31, 2016 11:1

@kelson42 my mistake I meant upload-apk.py

@kelson42
Copy link
Contributor Author

@mhutti1 You mean, you meant update-play-store.py?

@mhutti1
Copy link
Contributor

mhutti1 commented Apr 18, 2017

This should be implemented into our new build system however it ends up working.

@stale
Copy link

stale bot commented Jun 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@kelson42

This comment has been minimized.

@macgills
Copy link
Contributor

uploading APKs with an existing expansion. this is so developers do not have to go into the play console and manually associate our expansion files with each new apk, there are a host of gotchas when working with expansion files. This functionality is supported by gradle play publisher

@kelson42

This comment has been minimized.

@kelson42
Copy link
Contributor Author

@macgills great if we can do that almost out of the box. This sounds an important feature indeed.

@kelson42
Copy link
Contributor Author

@macgills From what I have heard recently, this is not so easy to do (anymore)? What is the status here?

@macgills
Copy link
Contributor

We couldn't use GPP for custom uploads so it is not implemented, it is possible afaik but we would probably need to add another config file on the root of kiwix-android-custom to offer options to the GitHub action on how it builds.

The Action uploads the artifact in draft and at that point the attached obb can be manually selected to be an older version if we so wish, obviously would be better if it were automatic

@kelson42
Copy link
Contributor Author

@macgills Thx, I descope it from the milestone for now.

@stale
Copy link

stale bot commented Jan 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@kelson42
Copy link
Contributor Author

kelson42 commented Jan 11, 2023

Seems to be a topic for kiwix/Kiwix-android-custom

@kelson42 kelson42 transferred this issue from kiwix/kiwix-android Jan 11, 2023
@kelson42
Copy link
Contributor Author

@MohitMaliDeveloper Is that not something automatically allowed now with bundle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants