Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Use schema store to get json schema #115

Open
Freed-Wu opened this issue Jan 21, 2024 · 6 comments
Open

[feature] Use schema store to get json schema #115

Freed-Wu opened this issue Jan 21, 2024 · 6 comments

Comments

@Freed-Wu
Copy link

https://github.com/kkiyama117/coc-toml/blob/main/src/index.ts#L64

Why not use schemastore to get json schema?

Related issue: neoclide/coc-json#75

@Freed-Wu
Copy link
Author

https://taplo.tamasfe.dev/configuration/developing-schemas.html#publishing:

Submitting schemas directly to Taplo is not possible anymore, and all JSON schemas should be submitted to the JSON Schema Store.

@Freed-Wu
Copy link
Author

Yes, https://github.com/tamasfe/taplo/tree/master/editors/vscode use schemastore.

@kkiyama117
Copy link
Owner

I think it is a very good suggestion, as are the other issues you have put up. I will work on it later if I can find the time, but I am currently a university student and I don't think I will have time to work on it for another month or so due to my graduation thesis, remaining credits and graduate exams.
This coc-toml is based on the alpha version of taplo's plugin for vscode, modified to fit the configuration of other coc plugins. If I remember correctly, taplo is now in a different major version from that time, and I think there are discrepancies in some functions and links such as schema, etc. because the internal structure is different. If you want these features immediately and can use Node.js, I hope you can make the changes and create a PR.

@kkiyama117
Copy link
Owner

Also, I now use a plugin structure in vim based on the denops ecosystem and do not use coc in main. That, and the private reasons mentioned above, have slowed down the updating of coc-toml. If you use coc regularly and you or someone you know is familiar with coc, nodejs or vim, and you are interested, please let me know in a separate issue as I will transfer this repository.

@Freed-Wu
Copy link
Author

someone you know is familiar with coc, nodejs or vim

How about https://github.com/coc-extensions?

@kkiyama117
Copy link
Owner

Sure. I'll discuss it there when I can take the time to reply properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants