This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
use OZ contracts #1558
Closed
use OZ contracts #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
suggested changes
Oct 31, 2024
cairo/kakarot-ssj/crates/contracts/src/kakarot_core/kakarot.cairo
Outdated
Show resolved
Hide resolved
cairo/kakarot-ssj/crates/contracts/src/test_contracts/test_upgradeable.cairo
Outdated
Show resolved
Hide resolved
- refac: transition to snake_case
- bump OZ's version to 0.18.0
enitrat
previously approved these changes
Oct 31, 2024
|
Sorry for the late reply. We've been pausing the development of kakarot for now. I'm cognizant that you spent some time doing this PR, so thank you. I will have to close it since I am cleaning a bit the repo and preparing for archival. Archiving the repo will solve issue of people working on stuff while we are not accepting new PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR:
2days
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1521
What is the new behavior?
Removed custom implementation of ownable, upgradeable and refactor ERC20 contract that were copy from OZ and added OZ contract dependencies.
This change is