Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources hangs on Models with no system-id attached #141

Open
Tethik opened this issue Jan 8, 2025 · 2 comments
Open

Resources hangs on Models with no system-id attached #141

Tethik opened this issue Jan 8, 2025 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Tethik
Copy link
Member

Tethik commented Jan 8, 2025

Screenshot 2025-01-08 at 10 20 16

When opening the resources tab on a threat model without a system-id, it fetches for a long time then returns an error.
This should be handled nicer.

@Tethik Tethik added bug Something isn't working good first issue Good for newcomers labels Jan 8, 2025
@Tyouxik
Copy link
Collaborator

Tyouxik commented Jan 8, 2025

It can be handled with a message informing that resources are not available for standalone models, or removing the resource tab.
Prevent fetching or return an empty list from the backend to avoid misusing resources.

@Tethik
Copy link
Member Author

Tethik commented Jan 8, 2025

I think technically resources could be available on standalone models, it depends on how/where they are fetched from. I'd let the backend decide, just ensure it's nicely rendered on the client when the list is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants