Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests should be matched based on "path info" #262

Open
Rican7 opened this issue Nov 12, 2014 · 0 comments
Open

Requests should be matched based on "path info" #262

Rican7 opened this issue Nov 12, 2014 · 0 comments
Assignees
Labels
Milestone

Comments

@Rican7
Copy link
Member

Rican7 commented Nov 12, 2014

Currently, requests are being matched based on their REQUEST_URI. This requires some special server environment handling and is actually not the ideal path to be checking during routing behavior.

Most routing libraries actually route based on a request's PATH_INFO, which can be pre-processed by PHP or the FGCI proxy server.

Unfortunately, the PATH_INFO request/environment variable can be a little strange under certain configurations, so it would probably be a good idea to use it as a primary and then fall back to the old REQUEST_URI if need be.

@Rican7 Rican7 added the Feature label Nov 12, 2014
@Rican7 Rican7 self-assigned this Nov 12, 2014
@Rican7 Rican7 added this to the 2.2 milestone Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant