Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag & drop doesn't work in a story with > 6k passages #1508

Open
3 of 4 tasks
hhrichards opened this issue Mar 21, 2024 · 2 comments
Open
3 of 4 tasks

Drag & drop doesn't work in a story with > 6k passages #1508

hhrichards opened this issue Mar 21, 2024 · 2 comments
Labels
bug Something isn't working P2 (should) Usage is significantly impeded, enhancements to cover major functionality gaps

Comments

@hhrichards
Copy link

Describe the bug.

I start to drag a passage with the mouse pressed. I release the mouse and click a second passage to drag. But it continues to drag the first passage, and not the second. This happens in documents with a large amount of passages where the UI is noticeably slower.

Steps to reproduce:

Try this on a document with over 6,000 passages. Drag and drop two passages that are in close proximity in a short amount of time.

Expected behavior:

The drag/drop functionality works as expected on a new project or one with a few hundred passages. But I'm experiencing this bug in a project with over 6,000 passages.

Additional context on this problem.

I'm working on a project with over 6,000 passages. Drag/drop functionality is quite slow. The bug is not present on a project with only 1,500 passages.

Twine version number

2.8.1

Does this problem occur with the web version of Twine or the desktop app?

Desktop app

What operating system does this problem occur on?

macOS

If this problem is occurring with the web version of Twine, what browser does it occur on?

None

Presubmission checklist

  • I am interested in working on code that would fix this bug. (This is not required to submit a bug report.)
  • I have done a search and believe that an issue does not already exist for this bug in the GitHub repository.
  • If this problem is occurring with the app version of Twine, it still happens after I remove the user.css file from my Twine folder. (You would've added this file yourself. If you don't understand this question, you can safely check this box.)
  • I have read and agree to abide by this project's Code of Conduct.
@hhrichards hhrichards added the bug Something isn't working label Mar 21, 2024
@klembot klembot changed the title Drag & drop issue on large projects. Dragging a second passage in close succession continues to drag the first passage Drag & drop doesn't work in a story with > 6k passages Mar 22, 2024
@klembot
Copy link
Owner

klembot commented Mar 22, 2024

I think this is just performance issues with a story that size, period--I have a feeling that events are getting processed out of order, or getting skipped, which is why it's acting so weird. My one suggestion right now would be to look at ways to break up your story into smaller ones in Twine and then later recombine using a CLI tool.

Would you be OK with uploading an example story of this size for testing?

@klembot klembot added the P2 (should) Usage is significantly impeded, enhancements to cover major functionality gaps label Mar 22, 2024
@hhrichards
Copy link
Author

Yes of course. l've sent you a DM you on Patreon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 (should) Usage is significantly impeded, enhancements to cover major functionality gaps
Projects
None yet
Development

No branches or pull requests

2 participants