Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pkl #338

Open
StefMa opened this issue Dec 28, 2024 · 3 comments
Open

Support for pkl #338

StefMa opened this issue Dec 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@StefMa
Copy link
Contributor

StefMa commented Dec 28, 2024

It would be great if this library has support for apples "new" configuration language pkl.

Some info can be found here:
apple/pkl#849

@knadh knadh added the enhancement New feature or request label Jan 6, 2025
@knadh
Copy link
Owner

knadh commented Feb 14, 2025

Perhaps we should close this as the aforementioned thread confirmed the hard dependency on the external pkl binary?

@StefMa
Copy link
Contributor Author

StefMa commented Feb 14, 2025

What's wrong with having the pkl binary as a dependency? 🤔 Sure not the most elegant solution, but if someone wants to use that 🤷‍♂️.

If you are against it, also fine for me. However, we might can also keep it until they lift the restriction with the binary? 🤔

@knadh
Copy link
Owner

knadh commented Feb 16, 2025

While koanf is agnostic to whatever happens in a provider, given that the pkl ecosystem (eg: docs) itself doesn't lend much clarity on how it works, feels a bit off ship a provider that has an external bin dependency.

That said, it's not a big deal. If you'd like to send a PR (which can clearly document that it requires the pkl bin to be installed), then it's fair enough I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants