Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch should take a context.Context #340

Open
cedws opened this issue Mar 3, 2025 · 0 comments
Open

Watch should take a context.Context #340

cedws opened this issue Mar 3, 2025 · 0 comments

Comments

@cedws
Copy link

cedws commented Mar 3, 2025

Watch() can be implemented on providers to enable watching configuration for changes.

Watching configuration requires creating a background goroutine since this function is not expected to block forever. However, there is no way to cancel this goroutine since Watch() does not take a context.Context. The goroutine will run for the lifetime of the the program unless aborted via some other mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant