Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to label or ignore requests in metrics #15795

Open
jan-stanek opened this issue Feb 27, 2025 · 1 comment
Open

Possibility to label or ignore requests in metrics #15795

jan-stanek opened this issue Feb 27, 2025 · 1 comment
Labels
kind/feature Well-understood/specified features, ready for coding.

Comments

@jan-stanek
Copy link

jan-stanek commented Feb 27, 2025

Describe the feature

Currently there is no possibility to ignore health check metrics in knative metrics. We have multiple knative services with different health check URL's which are called more often than other service endpoints, so the metrics are unusable for us, becase we can't distinguish between real traffic and healthchecks (we use knative as a part of https://github.com/kserve/kserve and want to have just traffic to the model in dashboards).

Related issues: #14581 #15646

Proposed solution: #15653, knative/docs#6177 (health check request have special header and these requests are ignored in metrics), another possibility is to add some label to metrics and filer them in tools like Grafana.

I hope that it's pretty easy and no google doc is needed.

@evankanderson

@dprotaso
Copy link
Member

dprotaso commented Mar 7, 2025

I hope that it's pretty easy and no google doc is needed.

I'd prefer a more flushed out proposal for this feature see: https://github.com/knative/community/blob/main/mechanics/FEATURE-TRACKS.md

The goal of the proposal is to surface questions which Evan has been doing in GitHub Issues: knative/docs#6177 (comment)

Part of this is defining what happens when revisions are scaled to zero etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Development

No branches or pull requests

2 participants