Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute parser #42

Open
vikiival opened this issue Jul 25, 2023 · 1 comment
Open

Attribute parser #42

vikiival opened this issue Jul 25, 2023 · 1 comment
Labels
$

Comments

@vikiival
Copy link
Member

It is possible that current on/off-chain attributes can be parsed not very well.

such as addresses

attributes look good on canary: https://canary.kodadot.xyz/stmn/gallery/34-2, except substrate addresses @vikiival I checked our code and it is most definately a string: "DhvRNnnsyykGpmaa9GMjK9H4DeeQojd5V5qCTWd1GoYwnTc"
Bildschirmfoto 2023-07-22 um 21 01 26

Bildschirmfoto 2023-07-23 um 11 26 15

Originally posted by @niklasp in Proof-Of-Chaos/website#68 (comment)
@vikiival vikiival added the $ label Jul 25, 2023
@jsidorenko
Copy link

Could be related: https://github.com/polkadot-js/apps/pull/9707/files#diff-d5055bf77f7f1372076474741c06e747d774427a74db38520caf777ddf3c39b0R75
I recently noticed that it's better to use .toPrimitive() instead of .toString() for metadata/attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsidorenko @vikiival