Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KodaDot Explorer Upgrade #2650

Open
17 of 20 tasks
XyloDrone opened this issue Mar 23, 2022 · 31 comments
Open
17 of 20 tasks

KodaDot Explorer Upgrade #2650

XyloDrone opened this issue Mar 23, 2022 · 31 comments
Labels
A-explorer A-search related to search components A-subsquid indexer issues to subsquid chief enhancement New feature or request

Comments

@XyloDrone XyloDrone added enhancement New feature or request A-search related to search components A-profile related to profile section A-explorer labels Mar 23, 2022
@prachi00
Copy link
Member

@XyloDrone sure

@yangwao yangwao added the chief label Mar 24, 2022
@yangwao yangwao pinned this issue Mar 24, 2022
@XyloDrone
Copy link
Author

Thanks for the info @roiLeo , I removed the tasks which are completed.

If something is a backend issue, do you guys need someone else to give a hand with these types of developments, is it more timely or..? :D

@vikiival
Copy link
Member

If something is a backend issue

It means that we need to update our rubick indexer so we have the data for the NFT gallery

is it more timely or..? :D

Well it depends on the change:

  • If we need to change the schema (save additional data or so) we basically have to reindex the Kusama chain which is like 8 million blocks (Eta 2-3 days)

Screenshot 2022-03-28 at 11 10 41

  • If we need just a resolver - we have the data, we just need to transform them to the meaningful format for the gallery it's a matter of hours to implement, test and release.

@XyloDrone
Copy link
Author

Thanks for the clarification @vikiival :D
Is there any chance that #1367 could be sorted with a resolver?
Artist have been vocal about this issue before and they stated how it messes up their profiles.

@vikiival
Copy link
Member

vikiival commented Mar 28, 2022

Is there any chance that #1367 could be sorted with a resolver?

So the fast solution:
we need to write a resolver that would return the same data kodadot/rubick#19

The problem:
We currently use magick for the artist profiles kodadot/magick#11

The fix:
I can write the query and resolver and if would someone would take it from there I would be super happy ❤️

@XyloDrone
Copy link
Author

Thanks @vikiival :D
@roiLeo any chance you can take this up from Viki once he has written the resolver :DDD Pretty please 👯
Or if there is someone else more suitable for such a quest feel free to reccommend them :3

@Jarsen136
Copy link
Contributor

Is there any chance that #1367 could be sorted with a resolver?

So the fast solution: we need to write a resolver that would return the same data kodadot/rubick#19

The problem: We currently use magick for the artist profiles vikiival/magick#11

The fix: I can write the query and resolver and if would someone would take it from there I would be super happy ❤️

Hi, I am willing to take it if you can help to write the resolver. @vikiival

@vikiival
Copy link
Member

vikiival commented Mar 28, 2022

@XyloDrone with the help of SubSquid Guys we found a workaround

If @Jarsen136 wants to pick that up the whole setup is here #1367 (comment)

@XyloDrone
Copy link
Author

Fab

@yangwao
Copy link
Member

yangwao commented Mar 31, 2022

Added one we talked with @petersopko that merging collections under explorer together is easier for further maintenance which I really agree on

@XyloDrone
Copy link
Author

@yangwao @petersopko I couldn't properly understand this, merging collections how? :D

@XyloDrone
Copy link
Author

Anybody wanna pick up #1231 ? Seems quite important to easily find artists / collections if you know what you are looking for as a collector...

@vikiival
Copy link
Member

vikiival commented Apr 1, 2022

Anybody wanna pick up #1231 ?

Looks like it was closed in favour of #2719

@XyloDrone
Copy link
Author

I'd say these are 2 different matters.
#1231 is the search engine; there will probably be users which know what they are looking for(nft/collection/artist) and they will want to easily find these... still missing easy search for artists... @roiLeo , u wanna grab it as you were commenting there? :DDD

Whilst #2719 is about browsing through artists/nfts/collections...seems like @prachi00 is on it :D

@Jarsen136 do you wanna grab the infinity scroll issues if there's nothing else on yer plate? #1582 + #1411

@yangwao
Copy link
Member

yangwao commented Apr 1, 2022

Highlighting Search of meaning which sort of underlying functionality would benefit explorer expansion and search!
Like literally family package 2in1 for a discounted price.

@Jarsen136
Copy link
Contributor

@Jarsen136 do you wanna grab the infinity scroll issues if there's nothing else on yer plate? #1582 + #1411

Personally, it seem very strange to have a pagination and infinite scroll at the same time.
If we keep only one of them, I can have a try : )

@XyloDrone
Copy link
Author

@yangwao @vikiival what do you guys think? I personally vote for infinity scroll, @cryptodamsky mentioned that some collectors asked in surveys for this option :D

@yangwao
Copy link
Member

yangwao commented Apr 1, 2022

@Jarsen136 do you wanna grab the infinity scroll issues if there's nothing else on yer plate? #1582 + #1411

Personally, it seem very strange to have a pagination and infinite scroll at the same time. If we keep only one of them, I can have a try : )

problem with infinity scroll hard to address (shareable URL) where are "you" in "feed" but I guess if we figure out a way to tackle let's go, but in general, #1582 has video how alza.sk has it yup

okay let's go.

@Jarsen136
Copy link
Contributor

problem with infinity scroll hard to address (shareable URL) where are "you" in "feed" but I guess if we figure out a way to tackle let's go, but in general, #1582 has video how alza.sk has it yup

okay let's go.

I have some ideas to address (shareable URL) where are "you" in "feed" without pagination.
Ok, I will have a try.

@preschian
Copy link
Member

problem with infinity scroll hard to address (shareable URL) where are "you" in "feed" but I guess if we figure out a way to tackle let's go, but in general, #1582 has video how alza.sk has it yup
okay let's go.

I have some ideas to address (shareable URL) where are "you" in "feed" without pagination. Ok, I will have a try.

Jarsen so cool 🚀

@XyloDrone
Copy link
Author

GM @Jarsen136 any updates on the infinity scroll issue(s) :D

@Jarsen136
Copy link
Contributor

GM @Jarsen136 any updates on the infinity scroll issue(s) :D

GM. This issue seems a little bit complex. I will try to make a demo of the collection page in the next two days. : )

@XyloDrone
Copy link
Author

No worries, take your time, looking forward to seeing it :D

@yangwao
Copy link
Member

yangwao commented Apr 27, 2022

Seems Infinite scroll is being made here, with few hiccups but fair ready!
#2859

@yangwao yangwao removed the A-profile related to profile section label Apr 27, 2022
@XyloDrone
Copy link
Author

Anybody want to take the backend stuff so we can get some snazzy filters in? 👀
@Jarsen136 @roiLeo @kkukelka @petersopko ? 🚀

@XyloDrone
Copy link
Author

Well done @Jarsen136 on the infinity scroll! 🥳

@roiLeo
Copy link
Contributor

roiLeo commented Apr 27, 2022

Anybody want to take the backend stuff so we can get some snazzy filters in? 👀 @Jarsen136 @roiLeo @kkukelka @petersopko ? 🚀

Thanks but I'll pass, it's not my field.

@XyloDrone
Copy link
Author

Good to know, what’s your preference usually? Just so I know, I’m assuming front end? :D

@roiLeo
Copy link
Contributor

roiLeo commented Apr 27, 2022

Good to know, what’s your preference usually? Just so I know, I’m assuming front end? :D

Yup, frontend & design

@petersopko
Copy link
Contributor

Anybody want to take the backend stuff so we can get some snazzy filters in? 👀 @Jarsen136 @roiLeo @kkukelka @petersopko ? 🚀

I'll take a look at some of the open subsquid tasks

@yangwao yangwao added the A-subsquid indexer issues to subsquid label May 6, 2022
@yangwao yangwao unpinned this issue Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-explorer A-search related to search components A-subsquid indexer issues to subsquid chief enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants