Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: authors not notified when comment visibility changes from "Reviewers" to "Authors and Reviewers" #373

Open
robgjansen opened this issue Nov 29, 2024 · 0 comments · May be fixed by #374

Comments

@robgjansen
Copy link

Sometimes reviewers write a comment with visibility set to "Reviewers", to solicit feedback on some questions they have for the authors. Later, a reviewer wants to send that comment to the authors, so they go back and edit that comment to change the visibility to "Authors and Reviewers" to make it visible to the authors too. When they do this, no email notification is being sent to the authors even though the interface does say that the authors will be notified. The reviewers are left waiting for a response to the posted questions, while the authors never realize a response is requested.

This issue was discover on v3.0.0. Just tested on 903edf1, and discovered that the bug still exists. See attached for reference.

Screenshot 2024-11-29 at 1 29 07 PM

I think the desired behavior is that when a comment is edited, if the visibility changes TO allow authors to view it FROM any type that does not allow authors to view it, we should send the author notification email.

robgjansen added a commit to robgjansen/hotcrp that referenced this issue Nov 29, 2024
@robgjansen robgjansen linked a pull request Nov 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant