This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Fix #2021: Allow users to be deleted #2123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds API endpoints to allow deleting users. Following patterns in the
rest of the API, to delete one user, use `DELETE
/api/v1/kolide/users/{id}" and to delete multiple users, `POST` an array
of ids to `/api/v1/kolide/users/delete`.
nyanshak
force-pushed
the
fix-2021-allow-users-to-be-deleted
branch
from
a51fcdd to
75c060a
Compare
|
Thanks for contributing this, and apologies for the delay in review. I'd like to get user deletion merged, but I am concerned about using soft-deletion as the strategy. Ideally I'd like to address #2146 and then hard-delete users. For now we have "disable" which is fairly similar to soft deletion. Do you have a specific use case for this right now? If not I'd like to hold off on merging until we can address #2146 and then try to do this more thoroughly including support in the frontend and/or fleetctl. |
|
I agree with that approach (hard-delete vs soft-delete). I was trying to follow the pattern I saw in the other tables, but was hoping to raise that as a separate issue later :) |
|
We can revisit this now that #2327 has been merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rest of the API, to delete one user, use
DELETE /api/v1/kolide/users/{id}" and to delete multiple users,POSTan array of ids to/api/v1/kolide/users/delete`.