From 88bd3e467ec9acc3711a0b28da69a1c9e6bf1b30 Mon Sep 17 00:00:00 2001 From: Pavel Sturc Date: Tue, 15 Aug 2023 11:35:52 +0200 Subject: [PATCH] feat: add ginkgolinter (#701) * test: add ginkgolinter to golangci * fix: apply ginkgolinter suggestions --- .golangci.yml | 3 +++ tests/build/build.go | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 6de654964..dc0fb4e0b 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,3 +1,6 @@ issues: exclude: - composites +linters: + enable: + - ginkgolinter diff --git a/tests/build/build.go b/tests/build/build.go index d5c12546a..aa08dd607 100644 --- a/tests/build/build.go +++ b/tests/build/build.go @@ -655,7 +655,7 @@ var _ = framework.BuildSuiteDescribe("Build service E2E tests", Label("build", " Specify("simple build can be triggered manually", func() { Expect(f.AsKubeAdmin.HasController.SetComponentAnnotation(componentName, controllers.BuildRequestAnnotationName, controllers.BuildRequestTriggerSimpleBuildAnnotationValue, testNamespace)).To(Succeed()) - Expect(f.AsKubeAdmin.HasController.WaitForComponentPipelineToBeFinished(component, "", 2)) + Expect(f.AsKubeAdmin.HasController.WaitForComponentPipelineToBeFinished(component, "", 2)).To(Succeed()) var buildStatus *controllers.BuildStatus @@ -683,7 +683,7 @@ var _ = framework.BuildSuiteDescribe("Build service E2E tests", Label("build", " return buildStatus.Simple != nil && buildStatus.Simple.BuildStartTime != lastBuildStartTime && buildStatus.Simple.ErrId == 0 && buildStatus.Simple.ErrMessage == "", nil }, timeout, interval).Should(BeTrue(), "build status has unexpected content") - Expect(f.AsKubeAdmin.TektonController.DeleteAllPipelineRunsInASpecificNamespace(testNamespace)) + Expect(f.AsKubeAdmin.TektonController.DeleteAllPipelineRunsInASpecificNamespace(testNamespace)).To(Succeed()) }) })