-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KFLUXUI-3): updated title for component creation dialog #122
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 80.49% 80.48% -0.02%
==========================================
Files 546 546
Lines 21261 21264 +3
Branches 5322 5325 +3
==========================================
Hits 17114 17114
- Misses 4121 4122 +1
- Partials 26 28 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
title="Create an application" | ||
breadcrumbs={[ | ||
...applicationBreadcrumbs, | ||
{ path: '#', name: `Create an ${isApplication ? 'Application' : 'Component'}` }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the name and the title enjoy the same content. so how about set it as a const?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And more it would be good if cases can be added for this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
When creating a component, the title will say 'Create an Component' which has the wrong article. Add another variable for it so it changes accordingly, otherwise looks good. |
Updated the component |
Fixes
Description
"Create an application" is updated as "Create a Component" when "Add Component" button clicked.
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: