Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KFLUXUI-3): updated title for component creation dialog #122

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rakshett
Copy link
Contributor

Fixes

Description

"Create an application" is updated as "Create a Component" when "Add Component" button clicked.

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Screenshot 2025-02-24 at 11 07 44 AM Screenshot 2025-02-24 at 11 07 59 AM

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (32c0531) to head (6e73416).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/ImportForm/ImportForm.tsx 0.00% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   80.49%   80.48%   -0.02%     
==========================================
  Files         546      546              
  Lines       21261    21264       +3     
  Branches     5322     5325       +3     
==========================================
  Hits        17114    17114              
- Misses       4121     4122       +1     
- Partials       26       28       +2     
Flag Coverage Δ
unittests 80.48% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/components/Applications/ApplicationListView.tsx 93.90% <ø> (ø)
src/components/ImportForm/ImportForm.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36559d1...6e73416. Read the comment docs.

title="Create an application"
breadcrumbs={[
...applicationBreadcrumbs,
{ path: '#', name: `Create an ${isApplication ? 'Application' : 'Component'}` },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the name and the title enjoy the same content. so how about set it as a const?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And more it would be good if cases can be added for this part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@marcin-michal
Copy link
Contributor

When creating a component, the title will say 'Create an Component' which has the wrong article. Add another variable for it so it changes accordingly, otherwise looks good.

@rakshett
Copy link
Contributor Author

When creating a component, the title will say 'Create an Component' which has the wrong article. Add another variable for it so it changes accordingly, otherwise looks good.

Updated the component

@rakshett rakshett requested a review from testcara February 27, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants