New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get physical #13

Merged

jarededwards merged 59 commits into main from get-physical

Nov 14, 2024

Contributor

jarededwards commented Nov 1, 2024

Description

Related Issue(s)

Fixes #

How to test

jarededwards added 6 commits

October 31, 2024 14:49


          initial commit for physical datacenter changes

51bed34


          update default ip, fix bootstrap path, add tink and colony deploys

d851eed


          wait for colony last and create secrets before waiting

8aec15d


          fix namespace for deployments

9c9d262


          create colony secrets and wait for colony

f6229dd


          shorten hack and fix file path for kcfg

a9dad9c

patrickdappollonio requested changes

View reviewed changes

Member

patrickdappollonio left a comment

It's always correct to return wrapped errors (that is, the value is err and the string contains %w otherwise errors become incomparable and undebuggeable.

I think the linter should've picked that up. If not, I'll try to fix it first time I'm back.

cmd/destroy.go Outdated Show resolved Hide resolved

cmd/destroy.go Outdated Show resolved Hide resolved

cmd/destroy.go Outdated Show resolved Hide resolved

cmd/destroy.go Outdated Show resolved Hide resolved

cmd/init.go Outdated Show resolved Hide resolved

internal/k8s/k8s.go Outdated Show resolved Hide resolved

internal/k8s/k8s.go Outdated Show resolved Hide resolved

internal/k8s/k8s.go Outdated Show resolved Hide resolved

internal/k8s/k8s.go Outdated Show resolved Hide resolved

internal/k8s/k8s.go Outdated Show resolved Hide resolved

jarededwards added 11 commits

November 1, 2024 11:19


          bypass client-go for kubectl temporarily

a17581b


          reassign k8s client to know about new crds

e0167b2


          remove hardcoded colony api key

59f5002


          add apiKey flag back

dea07fd


          comments and delete file if exists otherwise continue

8b73a4e


          fix v for w

a32d419


          wrap errors and return them

113e42c


          fix error log format

fd76636


          return an error if kubeconfig doesnt get created and add timeout

edd0c0f


          use poll until context and pass context through

6c0a076


          missing time increment

5b70f33

patrickdappollonio reviewed

View reviewed changes

cmd/destroy.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/colony/api.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/colony/api.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/colony/api.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/colony/api.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/colony/api.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/colony/api.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/docker/docker.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/docker/docker.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/docker/docker.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/docker/docker.go Outdated Show resolved Hide resolved

patrickdappollonio reviewed

View reviewed changes

internal/docker/docker.go Outdated Show resolved Hide resolved

jarededwards and others added 7 commits

November 6, 2024 12:46


          add blob store publish to public assets

bd9678f


          remove extra error condition

5baac23


          move manifests to colony repo

3c32c4b


          use the context from the parent func

90b7517

Co-authored-by: Patrick D'appollonio <[email protected]>


          fix trailling space in logs

f35f0a1


          remove usage fo fmt for infoF

98b9829


          fix error handling and check for existing containers

9c82949

patrickdappollonio requested changes

View reviewed changes

cmd/destroy.go Outdated Show resolved Hide resolved

cmd/init.go Outdated Show resolved Hide resolved

cmd/init.go Outdated Show resolved Hide resolved

cmd/init.go Outdated Show resolved Hide resolved

cmd/init.go Outdated Show resolved Hide resolved

internal/download/download.go Outdated Show resolved Hide resolved

internal/download/download.go Outdated Show resolved Hide resolved

internal/k8s/k8s.go Outdated Show resolved Hide resolved

internal/k8s/k8s.go Outdated Show resolved Hide resolved

internal/k8s/k8s.go Outdated Show resolved Hide resolved

jarededwards and others added 18 commits

November 11, 2024 22:30


          use logger on the client and handle errors for deployments

e0db3ac


          remove unused packages

985ee02


          fix log formatting

c65808f


          adopt os and remove dep ioutil

f8a87af


          Add new function to wait for file.


          Merge branch 'get-physical' of github.com:konstructio/colony into get…

2f4debd

…-physical


          handle error if download doesnt complete

cede5b9


          Clean up code structure. Return errors on places where it was being l…

f3e69e0

…ogged.


          Merge branch 'get-physical' of https://github.com/konstructio/colony …

8ef2884

…into get-physical


          Move delete function to a separate package.

d1c19fb


          Merge branch 'get-physical' of https://github.com/konstructio/colony …

8ee1542

…into get-physical


          Clean up standalone filesystem functions.

d853c43


          Add fs file.

6baa801


          Add golangci-lint.

83d968d


          Make function part of the struct.

82cb260


          Change function name.

8bfba6f


          pull in latest changes from upstream

d8e8529


          Check for bounds.

021f562

patrickdappollonio approved these changes

View reviewed changes

patrickdappollonio changed the title ~~draft: Get physical~~ Get physical

jarededwards merged commit ce762e6 into main

1 check passed

jarededwards deleted the get-physical branch

November 14, 2024 15:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet