Migrate Snowflake and flags to inline value classes #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukellmann
reviewed
Oct 24, 2023
common/src/commonMain/kotlin/entity/optional/OptionalSnowflake.kt
Outdated
Show resolved
Hide resolved
|
Is there an issue already for the problems with mockk? |
|
I've got wrong. This problem isn't related to inline classes, but to unsigned numbers. mockk/mockk#544 |
the issue you pointed to is now closed, is there any update on this? |
|
Yes, issue is closed, but it's not released yet |
zTrap
force-pushed
the
feature/snowflake-inline-class
branch
from
be60171 to
eeac1bd
Compare
zTrap
force-pushed
the
feature/snowflake-inline-class
branch
from
eeac1bd to
40e43ad
Compare
|
@lukellmann seems like all works fine with |
|
I'd like to discuss this some more before deciding what to do with this, see https://discord.com/channels/556525343595298817/1245773750486438060 |
zTrap
force-pushed
the
feature/snowflake-inline-class
branch
from
40e43ad to
e1ff834
Compare
|
i've updated the target branch btw |
lukellmann
requested changes
Jun 4, 2024
ksp-processors/src/main/kotlin/generation/shared/FileSpecForGenerationEntity.kt
Outdated
Show resolved
Hide resolved
ksp-processors/src/main/kotlin/generation/bitflags/BitFlagsGeneration.kt
Outdated
Show resolved
Hide resolved
zTrap
force-pushed
the
feature/snowflake-inline-class
branch
from
e1ff834 to
6027d6a
Compare
lukellmann
changed the title
lukellmann
approved these changes
Jun 5, 2024
lukellmann
changed the title
lukellmann
merged commit b427a29
into
kordlib:experiments/inline-value-classes
3 checks passed
|
these changes can be tested using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #711