resolve deprecations

Author: kose-y

src/distarray.jl

@@ -96,8 +96,8 @@ mutable struct MPIArray{T,N,A} <: AbstractArray{T,N}
         # return new{T,N,A}(sizes, localarray, partitioning, comm, win, rank, local_lengths(partitioning))
         return new{T,N,A}(sizes, localarray, partitioning, comm, rank, local_lengths(partitioning))
     end
-    MPIArray{T,N,A}(comm::MPI.Comm, partitions::NTuple{N,<:Integer}, sizes::Vararg{<:Integer,N}) where {T,N,A} = MPIArray{T,N,A}(comm, distribute.(sizes, partitions)...)
-    MPIArray{T,N,A}(::UndefInitializer, sizes::Vararg{<:Integer,N}) where {T,N,A} = MPIArray{T,N,A}(MPI.COMM_WORLD, (ones(Int, N-1)..., MPI.Comm_size(MPI.COMM_WORLD)), sizes...)
+    MPIArray{T,N,A}(comm::MPI.Comm, partitions::NTuple{N,<:Integer}, sizes::Vararg{Integer,N}) where {T,N,A} = MPIArray{T,N,A}(comm, distribute.(sizes, partitions)...)
+    MPIArray{T,N,A}(::UndefInitializer, sizes::Vararg{Integer,N}) where {T,N,A} = MPIArray{T,N,A}(MPI.COMM_WORLD, (ones(Int, N-1)..., MPI.Comm_size(MPI.COMM_WORLD)), sizes...)
 
 end
 
@@ -120,9 +120,9 @@ end
 
 MPIArray(init::Function, partition_sizes::Vararg{AbstractVector{<:Integer}, N};T=nothing,A=nothing) where N = MPIArray(MPI.COMM_WORLD, init, partition_sizes...;T=T,A=A)
 
-MPIArray(init::Function, partitions::NTuple{N,<:Integer}, sizes::Vararg{<:Integer,N};T=nothing, A=nothing) where N = MPIArray(init, distribute.(sizes, partitions)...; T=T,A=A)
+MPIArray(init::Function, partitions::NTuple{N,<:Integer}, sizes::Vararg{Integer,N};T=nothing, A=nothing) where N = MPIArray(init, distribute.(sizes, partitions)...; T=T,A=A)
 
-MPIArray(init::Function, sizes::Vararg{<:Integer,N}; T=nothing, A=nothing) where N = MPIArray(init, (ones(Int, N-1)..., MPI.Comm_size(MPI.COMM_WORLD)), sizes...; T=T, A=A)
+MPIArray(init::Function, sizes::Vararg{Integer,N}; T=nothing, A=nothing) where N = MPIArray(init, (ones(Int, N-1)..., MPI.Comm_size(MPI.COMM_WORLD)), sizes...; T=T, A=A)
 
 function MPIArray(comm::MPI.Comm, localarray::AbstractArray)
     #TODO, construct from localarrays 

src/distdirectives.jl

@@ -15,7 +15,7 @@ function Send(arr::AbstractArray, dest::Integer; tag::Integer=0)
 end
 
 function Recv!(arr::AbstractArray, src::Integer; tag::Integer=0)
-    MPI.Recv!(arr, src, tag, COMM_WORLD)
+    MPI.Recv!(arr, src, tag, COMM_WORLD, nothing)
 end
 
 function Isend(arr::AbstractArray, dest::Integer; tag::Integer=0)
@@ -26,8 +26,8 @@ function Irecv!(arr::AbstractArray, src::Integer; tag::Integer=0)
     MPI.Irecv!(arr, src, tag, COMM_WORLD)
 end
 
-function Reduce!(sendarr::AbstractArray, recvarr::AbstractArray; op=MPI.SUM, root::Integer=0)
-    MPI.Reduce!(sendarr, recvarr, op, root, COMM_WORLD)
+function Reduce!(sendarr::AbstractArray, recvarr::Union{AbstractArray, Nothing}; op=MPI.SUM, root::Integer=0)
+    MPI.Reduce!(MPI.RBuffer(sendarr, recvarr), op, root, COMM_WORLD)
 end
 
 function Allreduce!(arr::AbstractArray; op=MPI.SUM)
@@ -45,8 +45,8 @@ function Allgather!(sendarr::AbstractArray, recvarr::AbstractArray, count::Integ
 end
 
 function Allgatherv!(sendarr::AbstractArray, recvarr::AbstractArray, counts::Vector{<:Integer})
-#### TODO: auto-detect counts (is it doable?)
-    MPI.Allgatherv!(sendarr, recvarr, convert(Vector{Cint}, counts), COMM_WORLD)
+#### TODO: auto-detect counts (is it simple?)
+    MPI.Allgatherv!(sendarr, MPI.VBuffer(recvarr, counts), COMM_WORLD)
 end
 
 function Scatter!(sendarr::AbstractArray, recvarr::AbstractArray; root::Integer=0)

src/distlinalg.jl

@@ -81,7 +81,7 @@ function LinearAlgebra.mul!(C::MPIMatrix{T,AT}, A::MPIMatrix{T,AT}, B::Transpose
     sync()
     for i = 0:Size()-1
         # NOTE: an array is set to be contiguous only if the first indices are colon.
-        Reduce!(@view(tmp[:, C.partitioning[i+1][2]]), Rank() == i ? C.localarray : @view(tmp[:, C.partitioning[i+1][2]]); root=i)
+        Reduce!(@view(tmp[:, C.partitioning[i+1][2]]), Rank() == i ? C.localarray : nothing; root=i)
     end
     C
 end
@@ -352,7 +352,7 @@ function diag!(d::AbstractVector, M::MPIMatrix{T,A}) where {T,A}
     counts = reshape(map(x->convert(Cint, length(x[2])), M.partitioning), :)
     sync()
 
-    MPI.Allgatherv!(MPI.IN_PLACE, d, counts, MPI.COMM_WORLD)
+    MPI.Allgatherv!(MPI.VBuffer(d, counts), MPI.COMM_WORLD)
 end
 
 """

test/runtests.jl

@@ -18,8 +18,6 @@ testfiles = sort(filter(istest, readdir(testdir)))
 @info "Running DistStat tests" ArrayType nprocs
 
 @testset "$f" for f in testfiles
-    mpiexec() do cmd
-        run(`$cmd -n $nprocs $(Base.julia_cmd()) $(joinpath(testdir, f))`)
-        @test true
-    end
+    run(`$(mpiexec()) -n $nprocs $(Base.julia_cmd()) $(joinpath(testdir, f))`)
+    @test true
 end