Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded svg does not work in Illustrator #125

Closed
clausharup opened this issue May 8, 2022 · 10 comments
Closed

Downloaded svg does not work in Illustrator #125

clausharup opened this issue May 8, 2022 · 10 comments
Labels
reviewed Temporary label to review all open and closed PR

Comments

@clausharup
Copy link

I guess the use of clip-path rather than native path makes the .svg not working in Illustrator :-(

@chiptu
Copy link

chiptu commented May 24, 2022

I have also problem in canva

@HenkVanMaanen
Copy link
Contributor

Same problem. Does anybody have a solution?

@chiptu
Copy link

chiptu commented May 24, 2022

seems linked to this issue #92

@iamdangavin
Copy link

iamdangavin commented Jun 8, 2022

Forked this and I am working on a version that uses g if you are simply passing a color option. It groups the dots and corners separately and creates a style attribute with the appropriate classes for each g element. If you pass the gradient option it will perform how it currently does with using a clip-path to render whatever element you're using the gradient option on.

Once I get it cleaned up to handle that portion I will focus on getting the clip-path with the gradients cleaned up. Not trying to step on the creators toes here. I really like the options for this library, but I agree with everyone above that the clip-path solution kind of defeats the purpose of the svg use in other programs.

Example

qrcode

qrcode-svg-code

@HenkVanMaanen
Copy link
Contributor

HenkVanMaanen commented Jun 9, 2022

@iamdangavin very nice work! Do you know if this impacts the wrong dots orientation problem? See: sallandpioneers@638824f

And issue:
#49

@iamdangavin
Copy link

@HenkVanMaanen I wasn't aware of that issue yet, but good good to know. I modified my version to include that swap of the draw order that you referenced in: sallandpioneers@638824f

I will say, that I am only editing the QRSVG.ts file at the moment. I felt like for the canvas rendering (for me at least) the creation of the svg didn't matter too much because it's contained in the canvas object.

Still working through some things on my end so might take me about another week or so to get it available. Not sure if best plan is to get @kozakdenys to update his repo or we all combine forces and create a new one or something. Any input from anyone is welcome. I just know that it would be great to get this all updated and up on npm.

@HenkVanMaanen
Copy link
Contributor

@iamdangavin any update on this?

@chiptu
Copy link

chiptu commented Jul 13, 2022

@iamdangavin i would be curious too 👀

@kozakdenys
Copy link
Owner

Hi @clausharup @chiptu @HenkVanMaanen @iamdangavin
It should be partially fixed in version v1.8.0.
The image is still not displayed in Illustrator, but I can't fix it as Illustrator doesn't fully support SVG standard

@kozakdenys
Copy link
Owner

This issue will be opened unless we can find solutions for images

@kozakdenys kozakdenys added the reviewed Temporary label to review all open and closed PR label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Temporary label to review all open and closed PR
Projects
None yet
Development

No branches or pull requests

5 participants