Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Puppeteer executablePath #1

Closed
froi opened this issue Feb 25, 2023 · 4 comments
Closed

Error with Puppeteer executablePath #1

froi opened this issue Feb 25, 2023 · 4 comments

Comments

@froi
Copy link

froi commented Feb 25, 2023

¡Caballo, esto se ve bien tripioso!


After following the instructions in the README I'm getting this error

❯ bori "Hello"
file:///Users/froi/workspace/bori/node_modules/puppeteer-core/lib/esm/puppeteer/util/assert.js:25
        throw new Error(message);
              ^

Error: An `executablePath` or `channel` must be specified for `puppeteer-core`
    at assert (file:///Users/froi/workspace/bori/node_modules/puppeteer-core/lib/esm/puppeteer/util/assert.js:25:15)
    at ChromeLauncher.launch (file:///Users/froi/workspace/bori/node_modules/puppeteer-core/lib/esm/puppeteer/node/ChromeLauncher.js:63:13)
    at async mapPrompt (file:///Users/froi/workspace/bori/build/modality/prompt.mjs:4:25)
    at async file:///Users/froi/workspace/bori/build/main.mjs:25:16

Node.js v19.2.0

I'm not familiar with Puppeteer but I'm assuming that prompt.mts#L12 is to blame since I do not have process.env.CHROME_PATH defined in my env.

Maybe adding Chrome and the needed value for the environment variable as dependencies to the README would be enough?

@krismuniz
Copy link
Owner

Totalmente de acuerdo!

@froi
Copy link
Author

froi commented Feb 25, 2023

Me acabo de dar cuenta del .env.example. Creo que si añades el rename del archivo, el añadir de los valores y colocar el requisito del OPEN_API_TOKEN, estaría más que bien.

Happy to make the PR if you want 😉

@krismuniz
Copy link
Owner

@froi mandé some changes upstream, dime qué te parecen. Always open for PRs too!

@froi
Copy link
Author

froi commented Feb 25, 2023

Mano, good enough IMO. Closing this out 😉

@froi froi closed this as completed Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants