Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material conditionals lacking priority #43

Open
kristiker opened this issue Jan 1, 2023 · 1 comment
Open

Material conditionals lacking priority #43

kristiker opened this issue Jan 1, 2023 · 1 comment
Labels
enhancement New feature or request materials material importer

Comments

@kristiker
Copy link
Owner

kristiker commented Jan 1, 2023

The orange towers in de_dust2 look different with high gpu settings. S1Import does not prioritize higher order values and uses last key seen on file. Similar thing with _dx9 and hdr_dx9 blocks lacking a priority system.

// Sets the value when Shader Detail is High or higher
"GPU>=2?$color" "[ 1 0 0 ]" // Quoted parameter because of equal sign.
GPU<2  // Sets the values in the block if Shader Detail is below High.
{
	$envmap	env_cubemap
	$color "[ 0 0 1 ]"
}
@kristiker kristiker added enhancement New feature or request materials material importer labels Jan 1, 2023
@kristiker
Copy link
Owner Author

Also these blocks

// envmaptint_fix
"LightmappedGeneric"
{
    "$basetexture" "Metal/metalwall078a"
    "$surfaceprop" "metal"
    "%keywords" "combine"

    // NOTE: Even though env_cubemap is here, it will turned off for DX6
    // because $multipass 1 isn't defined
    "$envmap" "env_cubemap"
    "$envmaptint" "[ .56 .56 .75 ]"
    "$envmapcontrast" 1
    "$envmapsaturation" 1

    "LightmappedGeneric_DX9"
    {
        "$bumpmap" "metal/metalwall078a_normal"
        "$normalmapalphaenvmapmask" 1
        "$envmaptint" "[ .09 .1 .12]"
    }

    "LightmappedGeneric_DX8"
    {
        "$bumpmap" "metal/metalwall078a_normal"
        "$nodiffusebumplighting" 1
        "$normalmapalphaenvmapmask" 1
    }

    "LightmappedGeneric_NoBump_DX8"
    {
        "$basetexture" "metal/citadel_metalwall078a"
        "$basealphaenvmapmask" 1
    }

    "LightmappedGeneric_hdr_dx9"
    {
        // put HDR override stuff here
        "$envmaptint" "[ .09 .1 .12]"
        "$bumpmap" "metal/metalwall078a_normal"
        "$normalmapalphaenvmapmask" 1
    }
}

@kristiker kristiker reopened this Jan 6, 2023
@kristiker kristiker changed the title Material conditionals Material conditionals lacking priority Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request materials material importer
Projects
None yet
Development

No branches or pull requests

1 participant