Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent with interface name 'initial_model_url' and environment variable 'base_model_url' #14

Open
xiaochanwang opened this issue Aug 9, 2022 · 1 comment · May be fixed by #169
Open

Inconsistent with interface name 'initial_model_url' and environment variable 'base_model_url' #14

xiaochanwang opened this issue Aug 9, 2022 · 1 comment · May be fixed by #169
Assignees
@AryanNanda17
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@xiaochanwang
Copy link

What would you like to be added/modified:
While configuring algorithm.yaml, the pre-trained model url is specified as initial_model_url, however in test_algorithms/basemodel.py it is parsed and renamed as base_model_url.

Why is this needed:
This inconsistency might be confusing for algorithm developers. May I possibly recommend revising these two names to the same one rather than keeping this inconsistency.
@MooreZheng MooreZheng added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 13, 2024
@AryanNanda17
Copy link

working on this one!
/assign

AryanNanda17 added a commit to AryanNanda17/ianvs that referenced this issue Jan 2, 2025
@AryanNanda17
Inconsistent with interface name 'initial_model_url' and environment …
bb75e3d 
…variable 'base_model_url' kubeedge#14
@AryanNanda17 AryanNanda17 linked a pull request Jan 2, 2025 that will close this issue
Open
AryanNanda17 added a commit to AryanNanda17/ianvs that referenced this issue Jan 2, 2025
@AryanNanda17
Inconsistent with interface name 'initial_model_url' and environment …
e05f776 
…variable 'base_model_url' kubeedge#14

Signed-off-by: Aryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AryanNanda17 AryanNanda17

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inconsistent with interface name 'initial_model_url' and environment … AryanNanda17/ianvs
3 participants
@MooreZheng @xiaochanwang @AryanNanda17