Update MutatingWebhookConfiguration: Switch from objectSelector to AdmissionWebhookMatchConditions #2241
Conversation
google-oss-prow
bot
requested review from
anencore94,
johnugeorge and
tenzen-y
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
/lifecycle frozen |
|
@tenzen-y: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/remove-lifecycle stale |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
/remove-lifecycle stale |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
/remove-lifecycle stale |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
|
/remove-lifecycle stale |
|
@lianghao208 We stopped supporting v1.27. So, could you rebase and prepare a merge? |
Sure, I am working on it. |
Thank you! |
Signed-off-by: lianghao208 <[email protected]>
|
@tenzen-y |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/rerun-all |
|
/hold cancel |
…missionWebhookMatchConditions (kubeflow#2241) Signed-off-by: lianghao208 <[email protected]> Signed-off-by: mahdikhashan <[email protected]>
What this PR does / why we need it:
The AdmissionWebhookMatchConditions became beta feature in k8s 1.28, which means the feature-gate is enabled by default.
This PR switches the webhook configuration from objectSelector to AdmissionWebhookMatchConditions to exclude the katib-controller pod creation deadlock.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2206
Checklist: