Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] objective_metric_name to be required #2481

Closed
mahdikhashan opened this issue Jan 12, 2025 · 4 comments
Closed

[SDK] objective_metric_name to be required #2481

mahdikhashan opened this issue Jan 12, 2025 · 4 comments
Assignees
Labels
area/api good first issue Good for newcomers help wanted Extra attention is needed kind/feature

Comments

@mahdikhashan
Copy link
Contributor

What you would like to be added?

ref: kubeflow/website#3952 (comment)

Why is this needed?

TODO

Love this feature?

Give it a 👍 We prioritize the features with most 👍

@helenxie-bit
Copy link
Contributor

/remove-label lifecycle/needs-triage
/good-first-issue
/area api
/assign

Copy link

@helenxie-bit:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-label lifecycle/needs-triage
/good-first-issue
/area api
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added good first issue Good for newcomers area/api help wanted Extra attention is needed and removed lifecycle/needs-triage labels Jan 17, 2025
@helenxie-bit
Copy link
Contributor

After revisiting the tune API, I noticed that the default value of objective_type is actually set to "maximize" (I initially thought it was "minimize"). Given this, it seems challenging to define a default value for objective_metric_name that would be appropriate for both options (custom objective functions; importing models and datasets from external platforms). Considering this, I suggest we leave it undefined and close this issue. WDYT? @mahdikhashan 👀

@mahdikhashan
Copy link
Contributor Author

After revisiting the tune API, I noticed that the default value of objective_type is actually set to "maximize" (I initially thought it was "minimize"). Given this, it seems challenging to define a default value for objective_metric_name that would be appropriate for both options (custom objective functions; importing models and datasets from external platforms). Considering this, I suggest we leave it undefined and close this issue. WDYT? @mahdikhashan 👀

tbh i m not that much familiar with the codebase (not yet), so i respect your response and will close the issue. (only, we may want to label the idea somewhere with a todo for future.- only a raw idea)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api good first issue Good for newcomers help wanted Extra attention is needed kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants