From c3d6972535de4b49b0748474604b344f64c8d524 Mon Sep 17 00:00:00 2001 From: helenxie-bit Date: Wed, 29 Jan 2025 23:22:27 -0800 Subject: [PATCH 1/2] update the version of typing-extensions Signed-off-by: helenxie-bit --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 8820d472361..1affd1d4b03 100755 --- a/Makefile +++ b/Makefile @@ -163,7 +163,7 @@ prepare-pytest: # The sqlalchemy on which optuna depends requires typing-extensions>=4.6.0. # REF: https://github.com/kubeflow/katib/pull/2251 # TODO (tenzen-y): Once we upgrade libraries depended on typing-extensions==4.5.0, we can remove this line. - pip install typing-extensions==4.6.3 + pip install typing-extensions==4.10.0 prepare-pytest-testdata: ifeq ("$(wildcard $(TEST_TENSORFLOW_EVENT_FILE_PATH))", "") From acdb6b987bba5e9753f270d702d93f2838fc7739 Mon Sep 17 00:00:00 2001 From: helenxie-bit Date: Wed, 29 Jan 2025 23:32:55 -0800 Subject: [PATCH 2/2] update comment Signed-off-by: helenxie-bit --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1affd1d4b03..bd6ce2c4e64 100755 --- a/Makefile +++ b/Makefile @@ -160,8 +160,8 @@ prepare-pytest: pip install --prefer-binary -r cmd/suggestion/pbt/v1beta1/requirements.txt pip install --prefer-binary -r cmd/earlystopping/medianstop/v1beta1/requirements.txt pip install --prefer-binary -r cmd/metricscollector/v1beta1/tfevent-metricscollector/requirements.txt - # The sqlalchemy on which optuna depends requires typing-extensions>=4.6.0. - # REF: https://github.com/kubeflow/katib/pull/2251 + # `TypeIs` was introduced in typing-extensions 4.10.0, and torch 2.6.0 requires typing-extensions>=4.10.0. + # REF: https://github.com/kubeflow/katib/pull/2504 # TODO (tenzen-y): Once we upgrade libraries depended on typing-extensions==4.5.0, we can remove this line. pip install typing-extensions==4.10.0