Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce cpu, memory usage in CSI drivers on Windows #2010

Open
andyzhangx opened this issue Jul 27, 2024 · 1 comment
Open

reduce cpu, memory usage in CSI drivers on Windows #2010

andyzhangx opened this issue Jul 27, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@andyzhangx
Copy link
Member

andyzhangx commented Jul 27, 2024

Is your feature request related to a problem?/Why is this needed

powershell command would consume more memory and cpu on Windows, it's better replace with Golang API in Windows host process mode

  1. Test-Path $Env:remotepath
    // PathValid determines whether all elements of a path exist
    // https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.management/test-path?view=powershell-7
    // for a remote path, determines whether connection is ok
    // e.g. in a SMB server connection, if password is changed, connection will be lost, this func will return false
    replace with os.Stat, related to fix: mount-utils: Detect potential stale file handle kubernetes/kubernetes#106906

  2. (Get-Item -Path $Env:mount).Target
    replace with os.Readlink does not work: [WIP] fix: replace Get-Item powershell cmd with golang api azuredisk-csi-driver#2265

  3. there are other powershell commands in following code, it's better replacing them all with Golang APIs (search RunPowershellCmd)
    https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/pkg/os/smb/smb.go

Describe the solution you'd like in detail

Describe alternatives you've considered

Additional context

@andyzhangx andyzhangx added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 27, 2024
@andyzhangx andyzhangx changed the title replace powershell commands with Golang APIs in Windows host process mode reduce cpu, memory usage in CSI drivers on Windows Jul 27, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 26, 2024
@andyzhangx andyzhangx removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants