Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart to support to override deployment for all providers #516

Open
KannanThiru opened this issue May 2, 2024 · 4 comments · May be fixed by #525
Open

Helm chart to support to override deployment for all providers #516

KannanThiru opened this issue May 2, 2024 · 4 comments · May be fixed by #525
Assignees
@omerap12
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@KannanThiru
Copy link

KannanThiru commented May 2, 2024 •
edited
Loading

User Story

Unable to override ImageUrl to support private cloud when no route to external images

Detailed Description

Helm chart should have option to override imageurl and other features when needed across all providers.

Example output:

apiVersion: operator.cluster.x-k8s.io/v1alpha2
kind: InfrastructureProvider
metadata:
  name: vsphere
  namespace: vsphere-infrastructure-system
  annotations:
    "helm.sh/hook": "post-install"
    "helm.sh/hook-weight": "2"
spec:
  configSecret:
    name: vsphere-identity-secret
    namespace: default
  deployment:
    containers:
    - name: manager
      imageUrl: "test.org/cluster-api-vsphere/cluster-api-vsphere-controller:v1.10.0"

Adding support deployment on helm chart for each providers to helps better for private cloud.

Ex: infra.yaml

{{- if hasKey $.Values.deployment "infrastructure" }}
{{- range $key, $value := $.Values.deployment }}
  {{- if eq $key "infrastructure" }}
  deployment:
  {{- toYaml $value | nindent 4 }}
  {{- end }}
{{- end }}
{{- end }}

Ex: value.yaml file

deployment:
  core:
    containers:
    - name: manager
      imageUrl: "test.org/cluster-api/cluster-api-controller:v1.7.1"
  infrastructure:
    containers:
    - name: manager
      imageUrl: "test.org/cluster-api-vsphere/cluster-api-vsphere-controller:v1.10.0"

/kind feature
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 2, 2024
@omerap12
Copy link
Member

omerap12 commented May 9, 2024

Ill take it
/assign

@omerap12 omerap12 linked a pull request May 10, 2024 that will close this issue
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 6, 2024
@furkatgofurov7
Copy link
Member

/remove-lifecycle rotten
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2024
@furkatgofurov7 furkatgofurov7 added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omerap12 omerap12

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Add deployment overrides to templates omerap12/cluster-api-operator
5 participants
@KannanThiru @k8s-ci-robot @furkatgofurov7 @k8s-triage-robot @omerap12