Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider if KCP should log periodically status #11717

Open
fabriziopandini opened this issue Jan 20, 2025 · 6 comments
Open

Consider if KCP should log periodically status #11717

fabriziopandini opened this issue Jan 20, 2025 · 6 comments
Labels
area/provider/control-plane-kubeadm Issues or PRs related to KCP help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

What would you like to be added (User Story)?

As an operator Ii would like to easily triage what happened to a cluster's control plane

Detailed Description

#11693 introduced a func tha can generate key/value pairs describing the overall status of the control plane.

Those k/v pair, are then added to "Machine Create" and "Deleting Machine" log lines, thus providing a sort of history of how KCP evolved over time (and why). This is good.

However, unless users have monitoring system on top of CAPI, as of today by looking at logs it is complex to figure out what happened in between "Machine Create" and "Deleting Machine" oprations, e.g. did etcd had issue in the last two hours?

This issue is about discussing options to fill this gap, e.g

  • by logging overall status of the control plane e.g. every every 20m (at steady state, every other reconcile)
  • by logging overall status when it changes
  • ... (any idea striking a balance between getting more info and avoid noise/log size blow up is more than welcome)

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
/area provider/control-plane-kubeadm

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/control-plane-kubeadm Issues or PRs related to KCP needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2025
@sbueringer
Copy link
Member

We could also have some additional more frequent logs on a higher log-level, but that's not useful retroactively after running with a low log level.

@chrischdi chrischdi added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 22, 2025
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels Jan 22, 2025
@chrischdi
Copy link
Member

/help

We could use some help to figure out a good approach before jumping into implementation.

@k8s-ci-robot
Copy link
Contributor

@chrischdi:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

We could use some help to figure out a good approach before jumping into implementation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 22, 2025
@NMSVishal
Copy link

Hi @fabriziopandini ,

I would like to pick up the issue but I need guidance as I am new to the community.

Let me know where to start ,docs, codebase etc , I will go through it.

@chrischdi
Copy link
Member

Hey @NMSVishal , thanks for asking.

I'm sorry but I think this is not a good first issue to start with because we first have to figure out a good approach.

@NMSVishal
Copy link

Ok, can you please suggest a issue , to get started with code contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/control-plane-kubeadm Issues or PRs related to KCP help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants