-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Move Source implementations to a single folder #2685
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a4e8aca
to
a11bd44
Compare
Signed-off-by: Tim Ramlot <[email protected]>
a11bd44
to
22f4a15
Compare
@inteon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alvaroaleman could you take a look at this PR too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moves all the source logic to the same directory, making it easier to understand and refactor in the future.
What is or isn't easier to understand in terms of file layout extremely subjective while not mattering too much in practise due to IDE tooling. At the same time a change like this has a cost in review capacity and in that it breaks git blame. Given that there is no clear benefit but a clear cost I'm -1 to this.
Thanks for the feedback. I updated #2686 so it does no longer depend on this PR. |
Moves all the source logic to the same directory, making it easier to understand and refactor in the future.
Currently
pkg/source/source.go
contains the Channel, Informer and Func source, while the Kind source lives in thepkg/source/internal/kind.go
file.