Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--help not showing all feature gates / LoggingBetaOptions missing? #1630

Open
der-eismann opened this issue Feb 14, 2025 · 0 comments
Open
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@der-eismann
Copy link

What version of descheduler are you using?

descheduler version: v0.32.2

Does this issue reproduce with the latest release?

yes

Which descheduler CLI options are you using?

--help

Please provide a copy of your descheduler policy config file

n/a

What k8s version are you using (kubectl version)?

n/a

What did you do?

I wanted to enable JSON logging output. From looking at the --help output I get this:

--logging-format string
    Sets the log format. Permitted formats: "json" (gated by LoggingBetaOptions), "text". (default "text")

However after scrolling up to the feature gates there are only these:

      --feature-gates mapStringBool              A set of key=value pairs that describe feature gates for alpha/experimental features. Options are:
                                                 AllAlpha=true|false (ALPHA - default=false)
                                                 AllBeta=true|false (BETA - default=false)
                                                 EvictionsInBackground=true|false (ALPHA - default=false)

Now I don't want to enable all the beta features (I guess?), but at the same time I wonder if the LoggingBetaOptions gate even exists if it's not listed here.

What did you expect to see?

Either

--logging-format string
    Sets the log format. Permitted formats: "json", "text". (default "text")

or

      --feature-gates mapStringBool              A set of key=value pairs that describe feature gates for alpha/experimental features. Options are:
                                                 AllAlpha=true|false (ALPHA - default=false)
                                                 AllBeta=true|false (BETA - default=false)
                                                 LoggingBetaOptions=true|false (BETA - default=false)
                                                 EvictionsInBackground=true|false (ALPHA - default=false)

What did you see instead?
Confusing help texts

@der-eismann der-eismann added the kind/bug Categorizes issue or PR as related to a bug. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant