-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default LocalQueue #2936
Comments
@KPostOffice Do you assume that automatically https://kueue.sigs.k8s.io/docs/tasks/manage/setup_job_admission_policy/ generation? |
Are you referring to the example AdmissionPolicy outlined in the documentation? |
Yes, I indicated the ValidatingAdmissionPolicy. |
/assign |
Yeah, the assumption here would be that the policy would be in place |
If we are going to modify API to have "default" field, it might be tricky to validate that only one LQ is a default. Are we going to abandon setting LQ as default if another default LQ is present in the namespace (in this case we do not validate the object itself)? If we can have multiple default LQs, which one is an actual default? It could be a first one or the last one. To avoid those questions and the API change, I suggest to default LocalQueue that has |
@KPostOffice could you please tell if #2936 (comment) makes sense |
Let's have the "default" default LocalQueue and put the whole feature behind a feature gate, so we don't break anyone by accident. |
Using the |
It feels this feature requires a KEP, even if there is no "API" changed, we still introduce a feature-gate. Also, I feel the mechanism will evolve in the future, so having some reference we can update will be useful. It does not need to be long, just one pager to collect the use-cases and the proposed solution. |
+1 |
What would you like to be added:
I would like to be able to indicate a default LocalQueue per namespace to be used for a workload
Why is this needed:
If an administrator creates a single LocalQueue per namespace that all workloads are expected to use, defaulting the queue let's quota consumers ignore the need to include Queue specific request labels in their workloads and enforces the need to be associated with a Queue in order to be scheduled.
Completion requirements:
This enhancement requires the following artifacts:
The artifacts should be linked in subsequent comments.
The text was updated successfully, but these errors were encountered: