Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HierarchicalCohort: Support validations to avoid accidentaly Parent Cohort removal #3644

Open
3 tasks
tenzen-y opened this issue Nov 26, 2024 · 1 comment
Open
3 tasks
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tenzen-y
Copy link
Member

What would you like to be added:
We would like to add a validation webhook for the Cohort deletion operation.
The validations verify if the Cohort is not referred to by other Cohorts as a parent.

Why is this needed:
Currently, cluster admins can remove the Cohort even if the Cohort is referred to in other Cohorts .spec.parent field.
However, the deletion operation is not appropriate.
Ideally, the cluster admin should change the parent in the child Cohorts first before they remove the parent Cohort.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@tenzen-y tenzen-y added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 26, 2024
@tenzen-y
Copy link
Member Author

/cc @mimowo @gabesaba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant