Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Pod group labels and annotations to apis/ package #3653

Open
PBundyra opened this issue Nov 26, 2024 · 3 comments
Open

Move Pod group labels and annotations to apis/ package #3653

PBundyra opened this issue Nov 26, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@PBundyra
Copy link
Contributor

What would you like to be added:
Move consts

GroupNameLabel               = "kueue.x-k8s.io/pod-group-name"
GroupTotalCountAnnotation    = "kueue.x-k8s.io/pod-group-total-count"
GroupFastAdmissionAnnotation = "kueue.x-k8s.io/pod-group-fast-admission"
RoleHashAnnotation           = "kueue.x-k8s.io/role-hash"
RetriableInGroupAnnotation   = "kueue.x-k8s.io/retriable-in-group"

from pkg/controller/jobs/pod/pod_webhook.go to apis package

Why is this needed:
To improve code quality and API visibility

@PBundyra PBundyra added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 26, 2024
@tenzen-y
Copy link
Member

I think that we should not move those labels to apis package since those are not for a whole of Kueue projects.

Instead of that, I think that creating dedicated constants package or restructure the Pod, Deployment, and StatefulSet packages. For example, we might be able to restructure those packages based on the Pod directory.

This is a similar concept to KubeflowJobs.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 24, 2025
@PBundyra
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants